Skip to content

gtk3: only build docs on linux#72269

Merged
worldofpeace merged 1 commit intoNixOS:staging-nextfrom
worldofpeace:gtk-no-gtk-doc-macos
Oct 29, 2019
Merged

gtk3: only build docs on linux#72269
worldofpeace merged 1 commit intoNixOS:staging-nextfrom
worldofpeace:gtk-no-gtk-doc-macos

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 29, 2019 •
edited
Loading

Motivation for this change

cc @jtojnar @FRidh. This will fix the macos build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from 7c6f434c and vcunat October 29, 2019 20:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Oct 29, 2019
@roosemberth
Copy link
Contributor

roosemberth commented Oct 29, 2019

The current attribute gtk3 on the 19.09 channel does not generate the devdoc output (so I can't compare wrt this).

I was able to build this on linux, it generates the devdoc output with files with exactly the same hashes as HEAD^

@worldofpeace worldofpeace merged commit 374e6e9 into NixOS:staging-next Oct 29, 2019
@alyssais alyssais mentioned this pull request Mar 2, 2023
Merged
12 tasks
@jtojnar jtojnar deleted the gtk-no-gtk-doc-macos branch March 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhipple bhipple bhipple approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

No open projects
Staging
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@worldofpeace @roosemberth @bhipple