glibc: Fix building with musl on GCC 8#71480
Merged
nh2 merged 1 commit intoNixOS:masterfrom Oct 31, 2019
Merged
Conversation
This was referenced Oct 21, 2019
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
please include the motivation in the commit message directly instead of pointing to a place that may have an explanation. |
GCC 8 introduced new warnings that were picked up by -Werror; this commit makes them non-errors until fixed upstream. See * NixOS#68244 (comment) * nh2/static-haskell-nix#56 This commit takes care to not change the derivation for non-musl builds.
nh2
force-pushed
the
glibc-musl-gcc8-werror-fixes
branch
from
1ec1339 to
08ec575
Compare
Contributor
Author
@FRidh 👍 Done. |
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See
This commit takes care to not change the derivation for non-musl builds.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @matthewbauer @edolstra