Skip to content

yle-dl: 2.31 -> 20190614 #67656

Closed
jonringer wants to merge 5 commits intoNixOS:masterfrom
jonringer:bump-yle-dl
Closed

yle-dl: 2.31 -> 20190614 #67656
jonringer wants to merge 5 commits intoNixOS:masterfrom
jonringer:bump-yle-dl

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 28, 2019 •
edited
Loading

Motivation for this change

fixing @r-ryantm failed updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dezgeg

closure mostly due to ffmpeg + python + php

$ nix path-info -Sh ./result
/nix/store/3dnbdkxvnb46f9p4zv71xjzvj1326imw-yle-dl-20190614      413.9M

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67656
3 package were build:
python27Packages.mini-amf python37Packages.mini-amf yle-dl

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package labels Aug 28, 2019
@ofborg ofborg bot requested a review from dezgeg August 28, 2019 21:38
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 28, 2019
@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

Tests failing on aarch64-linux.

@jonringer
Copy link
Contributor Author

jonringer commented Aug 30, 2019 •
edited
Loading

Looks like endian-ness failures, since it's likely assumed-to-be-correct behavior, but fails; I'm not sure what to do but mark it as disabled for arm. Also, the project hasn't seen an update in 4 years, so I don't think opening a ticket to get arm support would be likely.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 30, 2019
@jonringer
Copy link
Contributor Author

jonringer commented Jan 9, 2020

gone stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonringer @mmahut