Skip to content

gimp3: init at 3.0.2#67576

Merged
jtojnar merged 12 commits intoNixOS:masterfrom
jtojnar:gimp-meson
Apr 16, 2025
Merged

gimp3: init at 3.0.2#67576
jtojnar merged 12 commits intoNixOS:masterfrom
jtojnar:gimp-meson

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 27, 2019

Trying to see if we need any changes on Darwin.

closes #333800

@jtojnar jtojnar added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Sep 9, 2019
@jtojnar jtojnar mentioned this pull request Oct 31, 2019
1 task
@jtojnar
Copy link
Member Author

jtojnar commented Nov 5, 2019

The gjs failure will require #72805

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 5, 2019
Copy link
Contributor

@worldofpeace worldofpeace Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this won't work if it ends up in a shebang for darwin (because wrappers).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah. Hoping for C wrappers before GIMP 3 is released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news! makeBinaryWrapper is a thing now: #124556

@jtojnar jtojnar force-pushed the gimp-meson branch 2 times, most recently from 715ab15 to f52c409 Compare November 20, 2019 22:02
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 20, 2019
@jtojnar jtojnar changed the title gimp: switch to unstable gimp: Testing dev version with Meson Nov 21, 2019
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 21, 2019
@jtojnar jtojnar force-pushed the gimp-meson branch 2 times, most recently from c750da1 to 359513f Compare November 21, 2019 22:58
@jtojnar
Copy link
Member Author

jtojnar commented Dec 13, 2019

@GrahamcOfBorg eval

@MithicSpirit
Copy link
Contributor

MithicSpirit commented Apr 5, 2025

Lastly, I get this strange log when closing the application:

Failed writing to '/home/sigmanificient/.config/GIMP/3.0/shortcutsrc': Error opening file “/home/sigmanificient/.config/GIMP/3.0/shortcutsrc”: Permission denied

but the file exists, and contain the following:


(action "file-print-gtk" "<Primary>p")

Make sure the file is writeable. I had the same issue, but doing chmod u+w on it fixed it (it also is created with the correct permissions after being deleted; maybe it was a bug in an earlier release?).

EDIT: it appears that it generates that file with permissions 444 when generating the default config. Probably an upstream bug.

@Readf0x
Copy link

Readf0x commented Apr 5, 2025

@Readf0x Which system are you running gimp3 on? It seems to work pretty smoothly on my NixOS environment (x64_84-linux) 😅
It takes less than 2 seconds to load on my computer 🤔

Very interesting, I'm also running NixOS x64_86-linux. I'll have to do some testing then, who knows what could be causing the issue. I suspect it's a configuration error on my end. Is your system configuration publicly available?

@Sigmanificient
Copy link
Member

Sigmanificient commented Apr 5, 2025

Yes, you can build a VM of my configuration using

nix run github:Sigmanificient/dotfiles#nixosConfigurations.Sigmachine.config.system.build.vm

You'll be able to log in with sigmanificient & password hello. Then, use startx to enter the graphical session (or alternatively, qtile start --backend wayland)

@Readf0x
Copy link

Readf0x commented Apr 6, 2025

@Sigmanificient In the generated image it still has gimp 2.10 instead of 3.
image

@Sigmanificient
Copy link
Member

Sigmanificient commented Apr 6, 2025

It's my system image, so it does not have gimp 3 currently (i guess i should include it to make it easier for tou to test 😅)

I made a branch that will provide gimp3 out of the box:

nix run github:Sigmanificient/dotfiles/gimp3#nixosConfigurations.Sigmachine.config.system.build.vm

image

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@jtojnar
Copy link
Member Author

jtojnar commented Apr 7, 2025

Looking at the source, the migration copies the ~/.config/GIMP/2.10/menurc file:

https://gitlab.gnome.org/GNOME/gimp/-/blob/14b1c1127379d775d361a1053db989d40b70044b/app/core/gimp-user-install.c#L1316

And the copying preserves the permissions of the original file:

https://gitlab.gnome.org/GNOME/gimp/-/blob/14b1c1127379d775d361a1053db989d40b70044b/app/config/gimpconfig-file.c#L232

So if the original file is read-only, the new one will be too:

$ ls -la ~/.config/GIMP/2.10/menurc
-r--r--r-- 1 jtojnar users 117 Apr 29  2020 /home/jtojnar/.config/GIMP/2.10/menurc

And looks like the original file was just copied from store:

https://gitlab.gnome.org/GNOME/gimp/-/blob/GIMP_2_10_38/app/core/gimp-user-install.c#L836

Sigmanificient and others added 12 commits April 15, 2025 10:01
The `gimpPlugins` should now support both versions.
Keep around for a while for legacy plug-in support.

Re-introducing it in a separate commit so that `gimp` expression retains continuous git history.
Superseded by GIMP 3 in the `gimp` package.
Temporarily, rename `gimp` to `gimp3` and `gimp2` back to `gimp`.

Revert once GIMP 3 works on Darwin again and performance regressions are debugged.
@jtojnar
Copy link
Member Author

jtojnar commented Apr 15, 2025

Rebased to resolve the merge conflict. Given that only some people are experiencing the issues and that we are keeping gimp pointing to GIMP 2 for now, I will merge this tomorrow.

The slowness and Darwin support can be resolved on master.

@jtojnar jtojnar merged commit 9be08d4 into NixOS:master Apr 16, 2025
21 of 22 checks passed
@jtojnar jtojnar deleted the gimp-meson branch April 16, 2025 15:32
@goyalyashpal
Copy link

goyalyashpal commented Apr 17, 2025

yayyyy!! finally merged. i've been tracking this for several weeks now. so glad. thanks a lot for all the efforts.

https://search.nixos.org/packages?show=gimp3&query=gimp&channel=unstable

@kolaente
Copy link
Member

Also handy to see when this lands in unstable: https://nixpk.gs/pr-tracker.html?pr=67576

@autumn-mck
Copy link

in unstable now 🥳

@Eveeifyeve
Copy link
Member

Eveeifyeve commented Apr 20, 2025

yayyyy!! finally merged. i've been tracking this for several weeks now. so glad. thanks a lot for all the efforts.

https://search.nixos.org/packages?show=gimp3&query=gimp&channel=unstable
Also handy to see when this lands in unstable: https://nixpk.gs/pr-tracker.html?pr=67576
in unstable now 🥳

Can you please not continue to comment here please. As many people are following this issue and this could be done somewhere else like in the matrix or disclosure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: gimp 2.10.38 → 3.0