Conversation
jonringer
left a comment
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM (A few nitpicks)
binary seems to work
leaf package
ff96e91 to
c1bc85d
Compare
|
oh yea, stdenv.cc.cc, guess you will need stdenv :(. Good atempt though :) you could try to do |
Not sure if I'm reading this correctly, but it doesn't seem to work diff --git a/pkgs/development/web/postman/default.nix b/pkgs/development/web/postman/default.nix
index b56cdf6c811..15038bdfbc7 100644
--- a/pkgs/development/web/postman/default.nix
+++ b/pkgs/development/web/postman/default.nix
@@ -84,7 +84,7 @@ stdenv.mkDerivation rec {
patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" _Postman
for file in $(find . -type f \( -name \*.node -o -name _Postman -o -name \*.so\* \) ); do
- patchelf --set-rpath ${libPath}:$out/share/postman $file || true
+ ORIGIN=$(patchelf --print-rpath $file); patchelf --set-rpath "libPath:$ORIGIN" $file || true
done
popd
'';
Furthermore, is breaking the default patching even a concern with binary packages like this? |
I'm not sure given the information, you can use
I find that most pre-built binaries are usually patched in this way :(. |
|
Ah. I think I just mistyped some things in my initial attempt based on your suggestions. |
|
Anything else I can do to get this merged? |
49be370 to
892830c
Compare
|
I have squashed the commits and moved the addition of myself to the list of maintainers (wait, do we need to do this per package or just for top-level maintainers?) @jonringer Any other thoughts before this gets merged? |
worldofpeace
left a comment
There was a problem hiding this comment.
You need to add various libs to buildInputs for the application to be properly wrapped.
Else, when you launch a file chooser within the app, it will crash with " No GSettings schemas are installed on the system". Note that's in pure environments.
Perhaps add libPath to buildInputs.
Moving everything into When attempting to remove @worldofpeace Given the strange behavior when I try to use |
|
@worldofpeace Thank you! This feels a lot less messy. |
worldofpeace
left a comment
There was a problem hiding this comment.
LGTM, verified file chooser worked with a cleared XDG_DATA_DIRS.
Yep, you can cleanup the git history and I'll merge 👍 |
- Remove gnome2 (NixOS#39976) - Use pango instead of gnome2.pango - Remove gnome2.GConf - Remove gtk2-x11 - Add at-spi2-atk dependency - Explicitly import packages rather than just pkgs or xorg - Refactor patchelf to be more generic - Use wrapGAppsHook - As this app uses GTK3 for the UI, we need to use wrapGAppsHook - Move libPath creation to postFixup - Remove dontPatchELF - Remove unnecessary Postman binary, only use _Postman - Remove unnecessary makeWrapper - Add dontConfigure - Remove unnecessary lib - Move libPath inputs to buildInputs
2bb50f3 to
e4c243d
Compare
Motivation for this change
https://www.getpostman.com/downloads/release-notes#changelog-linux-app-7.6.0
Things done
Major refactor
Testing
Not experiencing any issues from the little I've tested so far.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @xurei