Conversation
Profpatsch
left a comment
There was a problem hiding this comment.
Great, this removes another source of easy-to-make and hard-to-debug mistakes.
|
@GrahamcOfBorg build bazel.tests |
aherrmann
left a comment
There was a problem hiding this comment.
@Profpatsch Thanks for the review, I've addressed your comments, PTAL.
8f40298 to
f99d585
Compare
|
@GrahamcOfBorg build bazel bazel.tests If test pass, I will merge so we can assert #67835 before merging. |
|
@GrahamcOfBorg build bazel.tests |
|
The Darwin build has lots of instances of this error:
|
|
@Profpatsch also
That's strange, this PR doesn't touch |
Good question, here’s a dummy PR to test: #67999 |
|
Update: The tests pass on current master. |
eeabdb5 to
7cf7307
Compare
That's grown to a pretty big diff by now. There's a merge conflict with master now anyway. I've rebased. |
7cf7307 to
62e843d
Compare
|
@GrahamcOfBorg build bazel.tests |
|
I think ofBorg isn’t listening to Members yet; |
|
Hm, now there’s still one test failing on Darwin: |
|
Ping. So close :) |
To point to the custom bash instead of `/nix/store.../bin/env bash`.
Fail on any form of `bin/env ...` shebang.
62e843d to
1f3187c
Compare
|
rebased on latest master. |
|
@GrahamcOfBorg build bazel.tests |
As suggested by @Profpatsch in #66718 (comment) this PR adds a test to Bazel checking that shebangs have been patched appropriately.
This test flagged a few more instances of invalid python shebangs which are also fixed by this PR.
Motivation for this change
See #66718 (comment)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @Profpatsch