zlib: Add comments regarding static/shared linking#66486
Merged
mmahut merged 1 commit intoNixOS:masterfrom Aug 12, 2019
Merged
Conversation
60 tasks
nh2
force-pushed
the
zlib-static-shared-comments
branch
from
fde78cc to
bda6618
Compare
11 tasks
Contributor
|
@GrahamcOfBorg eval |
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
@nh2 thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main explanation was taken from commit:
The
SHARED_MODE=1bit was originally introduced in commit:Motivation
Spending hours to figure out why the zlib build behaves different from other builds, and how.
I don't claim the current approach is good, but at least now it's explained.
Things done