Skip to content

vimPlugins.coc-nvim: 0.0.71 -> 0.0.72#64411

Merged
teto merged 1 commit intoNixOS:masterfrom
teto:coc_update
Jul 8, 2019
Merged

vimPlugins.coc-nvim: 0.0.71 -> 0.0.72#64411
teto merged 1 commit intoNixOS:masterfrom
teto:coc_update

Conversation

@teto
Copy link
Member

@teto teto commented Jul 7, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 7, 2019
@teto
Copy link
Member Author

teto commented Jul 7, 2019

I suppose we should pin the runtime to the binary version. I've noticed recently that some coc commands were ineffective (hence this PR). In a next update maybe.

@teto teto merged commit 566c8fd into NixOS:master Jul 8, 2019
@teto teto deleted the coc_update branch July 8, 2019 02:40
@malob malob mentioned this pull request Jul 8, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rvolosatovs rvolosatovs rvolosatovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teto @rvolosatovs