Skip to content

Comments

meson: enable auto_features by default#63493

Merged
worldofpeace merged 14 commits intoNixOS:stagingfrom
jtojnar:meson-auto-features
Jun 25, 2019
Merged

meson: enable auto_features by default#63493
worldofpeace merged 14 commits intoNixOS:stagingfrom
jtojnar:meson-auto-features

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Jun 19, 2019 •
edited
Loading

We disabled them by default when they were introduced in

#42994

but enabling them probably makes more sense:

#54398
#63491

We will probably need to adjust dependencies like in #63491 all over the place.

@jtojnar jtojnar mentioned this pull request Jun 19, 2019
Merged
1 task
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 19, 2019
@jtojnar jtojnar force-pushed the meson-auto-features branch from e201510 to a16fcde Compare June 19, 2019 14:20
@jtojnar
Copy link
Member Author

jtojnar commented Jun 19, 2019

Oops, wrong syntax.

@grahamc
Copy link
Member

grahamc commented Jun 20, 2019

Jobset created: https://hydra.nixos.org/jobset/nixpkgs/pr-63493-meson-auto-features

@jtojnar
Copy link
Member Author

jtojnar commented Jun 20, 2019

Evaluation compared to one from a jobset building a commit this PR is based on: https://hydra.nixos.org/eval/1526405?compare=1525113

@jtojnar
Copy link
Member Author

jtojnar commented Jun 24, 2019

The failures are fewer than I expected. Perhaps more will show up once we fix the libs.

@jtojnar
Copy link
Member Author

jtojnar commented Jun 24, 2019

Pushed the fixes, time for round two. Did not rebase yet so that we could have clearer picture which failures are caused by this and which by something else.

Also, I will be leaving for a month of mostly-offline vacation without a PC soon, so feel free to finish this in my absence.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 24, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 24, 2019

Pushed the fixes, time for round two. Did not rebase yet so that we could have clearer picture which failures are caused by this and which by something else.

Also, I will be leaving for a month of mostly-offline vacation without a PC soon, so feel free to finish this in my absence.

Sounds good 👍 I can finish this.

@worldofpeace worldofpeace self-assigned this Jun 24, 2019
@jtojnar jtojnar force-pushed the meson-auto-features branch from 4fa40c5 to 1880edc Compare June 25, 2019 15:55
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2019
@jtojnar jtojnar force-pushed the meson-auto-features branch from 1880edc to e64a975 Compare June 25, 2019 16:12
jtojnar added 12 commits June 25, 2019 18:24
@jtojnar
meson: enable auto_features by default
e529ec3 
We disabled them by default when they were introduced in

NixOS#42994

but enabling them probably makes more sense:

NixOS#54398
NixOS#63491
@jtojnar
meson: do not download wraps
0fd5abb
@jtojnar
meson: use plain buildtype
41c575b 
This should allow us to inherit optimization/striping from stdenv
@jtojnar
gnome3.gnome-desktop: add libudev
76d85e4
@jtojnar
gnome3.tracker-miners: do not add auto_features=enabled
4fa19ba 
Meson setup hook now defaults to this.
@jtojnar
girara: fix build with auto_features=enabled
3238567 
Also split multiple outputs and enable tests.
@jtojnar
grim: fix build with auto_features=enabled
592a520
@jtojnar
wlroots: fix build with auto_features=enabled
5779747
@jtojnar
ncmpc: fix build with auto_features=enabled
4abfebf
@jtojnar
zathura: fix build with auto_features=enabled
4bc87ff
@jtojnar
spice-gtk: remove auto_features=enabled from expression
c3fe79e 
It is now default
@jtojnar
wl-clipboard: remove auto_features=enabled from expression
1811e91 
It is now the default.
@jtojnar jtojnar force-pushed the meson-auto-features branch from e64a975 to ac404cf Compare June 25, 2019 16:25
@worldofpeace worldofpeace merged commit 94e8afc into NixOS:staging Jun 25, 2019
@jtojnar jtojnar deleted the meson-auto-features branch June 25, 2019 16:49
@worldofpeace

This comment has been minimized.

Sign in to view
@nixos-discourse
Copy link

nixos-discourse commented Jun 25, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/psa-meson-now-building-all-auto-detected-features/3271/1

@jtojnar jtojnar mentioned this pull request Jun 25, 2019
Closed
@tadeokondrak tadeokondrak mentioned this pull request Jul 8, 2019
Closed
10 tasks
@jtojnar jtojnar mentioned this pull request Jul 14, 2019
Merged
10 tasks
@uninsane uninsane mentioned this pull request May 30, 2024
Closed
13 tasks
@Billli11 Billli11 mentioned this pull request Jun 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@worldofpeace worldofpeace

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtojnar @grahamc @worldofpeace @nixos-discourse