Skip to content

Comments

gnome3.tracker-miners: enable auto_features#63491

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:tracker-features
Jun 19, 2019
Merged

gnome3.tracker-miners: enable auto_features#63491
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:tracker-features

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Jun 19, 2019

When tracker-miners switched from booleans to features, we were no longer building majority of the miners, since we disable auto_features by default.

cc @worldofpeace

  • built in sandbox on NixOS

When tracker-miners switched from booleans to features, we were no longer building
majority of the miners, since we disable auto_features by default.
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 19, 2019
@ofborg ofborg bot requested review from hedning and worldofpeace June 19, 2019 01:23
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 19, 2019
@worldofpeace
Copy link
Contributor

Testing now. Looks good though.

@jtojnar
Copy link
Member Author

jtojnar commented Jun 19, 2019

#63493 will enable it globally.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activates fine, extract-modules are there.

@jtojnar jtojnar merged commit e0a21aa into NixOS:master Jun 19, 2019
@jtojnar jtojnar deleted the tracker-features branch June 19, 2019 01:56
jtojnar added a commit to jtojnar/nixpkgs that referenced this pull request Jun 25, 2019
We disabled them by default when they were introduced in

NixOS#42994

but enabling them probably makes more sense:

NixOS#54398
NixOS#63491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants