Skip to content

nixos/nagios: module updates#62061

Merged
aanderse merged 3 commits intoNixOS:masterfrom
aanderse:nagios
Jul 3, 2019
Merged

nixos/nagios: module updates#62061
aanderse merged 3 commits intoNixOS:masterfrom
aanderse:nagios

Conversation

@aanderse
Copy link
Member

@aanderse aanderse commented May 25, 2019

Motivation for this change

#55370
#53852

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse mentioned this pull request May 25, 2019
Merged
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 25, 2019
@aanderse aanderse marked this pull request as ready for review June 11, 2019 17:06
@aanderse aanderse requested review from flokli, nh2 and peterhoeg June 11, 2019 17:11
@nh2
Copy link
Contributor

nh2 commented Jun 11, 2019

I'm no Nagios user or expert, but I approve of the PermissionsStartOnly = true; removal that one of the commits implements.

peterhoeg
peterhoeg reviewed Jun 12, 2019
View reviewed changes
@aanderse aanderse merged commit ec80ffc into NixOS:master Jul 3, 2019
@aanderse aanderse deleted the nagios branch July 29, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterhoeg peterhoeg peterhoeg left review comments

@flokli flokli Awaiting requested review from flokli

@nh2 nh2 Awaiting requested review from nh2

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aanderse @nh2 @peterhoeg