buildRustCrate: Fix #60125 - Always set additional env variables during build#60127
Merged
dywedir merged 1 commit intoNixOS:masterfrom Apr 24, 2019
Merged
buildRustCrate: Fix #60125 - Always set additional env variables during build#60127dywedir merged 1 commit intoNixOS:masterfrom
dywedir merged 1 commit intoNixOS:masterfrom
Conversation
…d CARGO_PKG_HOMEPAGE (as cargo does)
Contributor
|
Looks good to me. I just updated the master branch of Carnix, this should be included in the next version. |
ofborg
bot
added
6.topic: rust
Member
|
Thanks! |
kolloch
added a commit
to nix-community/crate2nix
that referenced
this pull request
Apr 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namely
CARGO_PKG_VERSION_PREandCARGO_PKG_HOMEPAGE(as cargo does)
@P-E-Meunier
Motivation for this change
The
builtcrate assumes that these environment variables are always set at build time. Cargo does that. Since we are emulating cargo, we should, too.Things done
I build the crate that failed before using the update nixpkgs.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)