all-packages: try withing spliced packages.#58327
Closed
Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Closed
all-packages: try withing spliced packages.#58327Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
withing spliced packages.#58327Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Conversation
This is an experiment. On one hand, it should unbreak some cross things, on the other, if `inherit` is used for things other than overriding it will lead to "doubly spliced" packages, which is an insane mess.
This was referenced Mar 26, 2019
Open
Member
|
What's the status of this? |
Member
Author
|
It's not the big win thought it was and breaks other things. I would rather not do this. |
Member
|
Closing then |
Member
Author
|
Thanks! |
10 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is an experiment. On one hand, it should unbreak some cross things,
on the other, if
inheritis used for things other than overriding itwill lead to "doubly spliced" packages, which is an insane mess.
CC @matthewbauer
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)