Skip to content

Comments

nix: replace build utils with host utils in config.nix#58104

Closed
illegalprime wants to merge 1 commit intoNixOS:masterfrom
illegalprime:nix-cross-corepkgs
Closed

nix: replace build utils with host utils in config.nix#58104
illegalprime wants to merge 1 commit intoNixOS:masterfrom
illegalprime:nix-cross-corepkgs

Conversation

@illegalprime
Copy link
Member

@illegalprime illegalprime commented Mar 22, 2019

Motivation for this change

When cross-compiling nix build-time deps are saved in config.nix and in profile.d/nix.sh, this will make the correct replacements before install-time to ensure the right dependencies are added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from edolstra March 22, 2019 03:07
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 22, 2019
@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Mar 24, 2019
@matthewbauer matthewbauer mentioned this pull request Mar 28, 2019
Merged
@doronbehar
Copy link
Contributor

doronbehar commented Mar 4, 2020

@illegalprime Could you have a look at the merge conflicts?

@doronbehar
Copy link
Contributor

doronbehar commented May 16, 2020

Closing as OP seems unmotivated to fix merge conflicts so perhaps the issue this PR originally solved was fixed at NixOS/nix#2748 .

@doronbehar doronbehar closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@illegalprime @doronbehar @veprbl @GrahamcOfBorg