Skip to content

python3Packages.astropy: disable build-date-dependent irreproducible test - #579447

Merged
vcunat merged 1 commit into
NixOS:staging-nextfrom
nh2:astropy-disable-date-dependent-test
Oct 29, 2026
Merged

vcunat merged 1 commit into
NixOS:staging-nextfrom
nh2:astropy-disable-date-dependent-test

Conversation

@nh2

@nh2 nh2 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Trying to patch the brotli CVE fix (#577796) into an older nixpkgs, I noticed software doesn't build because astropy being its dependency has a test that fails 300 days after the release of some celestial data table.

There's no place for "time bomb tests" in nixpkgs.

Things done

  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
  • Follows the automation/AI policy.
  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • aarch64-darwin
  • Tested, as applicable:
    • Test-disabling only
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.

@nh2
nh2 requested review from KentJames and doronbehar October 27, 2026 00:03
@nh2 nh2 self-assigned this Oct 27, 2026
@nh2 nh2 added the 6.topic: reproducible builds Run nix-build twice and get the same result. label Oct 27, 2026
@nh2
nh2 force-pushed the astropy-disable-date-dependent-test branch 2 times, most recently from d5c8b3d to 65c3720 Compare October 27, 2026 00:04
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. llm-assisted Contributions that include code generation with LLMs 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 27, 2026
@nh2

nh2 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

…test

See: astropy/astropy#20725

Assisted-by: Claude Opus 5.5 in Zoo Code, human review.
@nh2
nh2 force-pushed the astropy-disable-date-dependent-test branch from 65c3720 to 960a3a1 Compare October 27, 2026 02:33
@vcunat

vcunat commented Oct 27, 2026

Copy link
Copy Markdown
Member

Nit: I'm not 100% sure if this is worth doing on master already instead of going to staging now and getting there in about a week. Either way, thanks for looking into it; I picked it to staging-next-26.05 as 70077f9

@nh2

nh2 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Nit: I'm not 100% sure if this is worth doing on master already instead of going to staging now and getting there in about a week.

@vcunat I agree; I wasn't aware of the other PR #579426 by the time I made mine, nor the mass rebuild that that one pointed out.

Switching this one to target staging.

@nh2
nh2 changed the base branch from master to staging October 27, 2026 19:08
@nixpkgs-ci nixpkgs-ci Bot closed this Oct 27, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Oct 27, 2026
@vcunat
vcunat changed the base branch from staging to staging-next October 29, 2026 11:33
@nixpkgs-ci nixpkgs-ci Bot closed this Oct 29, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Oct 29, 2026
@vcunat
vcunat added this pull request to the merge queue Oct 29, 2026
Merged via the queue into NixOS:staging-next with commit 015c84d Oct 29, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 6.topic: reproducible builds Run nix-build twice and get the same result. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. llm-assisted Contributions that include code generation with LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants