Skip to content

virtmanager: Fix gobject-introspection#57385

Merged
xeji merged 1 commit intoNixOS:masterfrom
FlorianFranzen:virtmanager
Mar 12, 2019
Merged

virtmanager: Fix gobject-introspection#57385
xeji merged 1 commit intoNixOS:masterfrom
FlorianFranzen:virtmanager

Conversation

@FlorianFranzen
Copy link
Contributor

@FlorianFranzen FlorianFranzen commented Mar 11, 2019

Motivation for this change

Fixes #56943 till underlying issue can be resolved.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Member

jtojnar commented Mar 11, 2019

Can you add a comment linking to the issue?

@FlorianFranzen
Copy link
Contributor Author

FlorianFranzen commented Mar 11, 2019

@jtojnar Sure, no problem. Keep in mind, that this is not currently the only derivation using this fix, for example see udiskie.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 11, 2019
@xeji
Copy link
Contributor

xeji commented Mar 12, 2019

@GrahamcOfBorg build virtmanager

@xeji xeji merged commit 871c1d5 into NixOS:master Mar 12, 2019
@lheckemann
Copy link
Member

lheckemann commented Mar 19, 2019

Should this be backported to 19.03, or should we wait for the "proper" fix?

@timor
Copy link
Member

timor commented Apr 8, 2019

+1 for backporting to 19.03

xeji pushed a commit that referenced this pull request Apr 8, 2019
@FlorianFranzen @xeji
virtmanager: Fix gobject-introspection (#57385)
e548fd1 
(cherry picked from commit 871c1d5)
@xeji
Copy link
Contributor

xeji commented Apr 8, 2019

backported to 19.03 in e548fd1

@FlorianFranzen FlorianFranzen deleted the virtmanager branch April 25, 2019 08:44
@worldofpeace worldofpeace mentioned this pull request Jun 4, 2019
Closed
@emmanuelrosa emmanuelrosa mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@fpletz fpletz Awaiting requested review from fpletz

@qknight qknight Awaiting requested review from qknight

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setup hook of gobject-introspection in nativeBuildInputs does not run with strictDeps

6 participants

@FlorianFranzen @jtojnar @xeji @lheckemann @timor @GrahamcOfBorg