zram: revert "change default algorithm to zstd" (19.03)#56856
Merged
danbst merged 1 commit intoNixOS:release-19.03from Mar 7, 2019
Merged
zram: revert "change default algorithm to zstd" (19.03)#56856danbst merged 1 commit intoNixOS:release-19.03from
danbst merged 1 commit intoNixOS:release-19.03from
Conversation
19.03 default kernel is still 4.14, which doesn't support zstd. So, zramSwap in current fasion fails on default kernel.
Contributor
Author
|
cc @samueldr |
Contributor
Author
|
🤔 I hope there won't be problem that this has to be backported to master, right? Or should I first commit to master and then backport to 19.03? |
GrahamcOfBorg
added
6.topic: nixos
worldofpeace
approved these changes
Mar 5, 2019
Contributor
worldofpeace
left a comment
worldofpeace
left a comment
There was a problem hiding this comment.
Looks good.
I think cherry-picking to master from 19.03 would be weird though.
Contributor
Author
|
neverless, 🍒 -ed this to master ef1911d . Will do better next time |
danbst
added a commit
that referenced
this pull request
Mar 7, 2019
19.03 default kernel is still 4.14, which doesn't support zstd. So, zramSwap in current fasion fails on default kernel.
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
19.03 default kernel is still 4.14, which doesn't support zstd. So, zramSwap in current fasion fails on default kernel.
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
19.03 default kernel is still 4.14, which doesn't support zstd. So, zramSwap in current fasion fails on default kernel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
19.03 default kernel is still 4.14, which doesn't support zstd. So,
zramSwap in current fasion fails on default kernel.
Kernel was revert after my zram-zstd patch landed #55092