cmake: fix darwin bootstrapping#56291
Merged
vcunat merged 3 commits intoNixOS:staging-nextfrom Feb 24, 2019
Merged
Conversation
lzma is part of the stdenv but not during bootstrapping?
Member
|
Nitpick idea: what about applying darwin-only patches only on darwin? That way we won't need to rebuild elsewhere when touching them (in future). |
Member
Author
|
I'm not a fan of conditional patches, but I could make this a darwin only change if we don't want to rebuild linux packages on staging-next right now. |
GrahamcOfBorg
added
the
10.rebuild-darwin-stdenv
GrahamcOfBorg
requested review from
andir,
copumpkin,
edolstra,
lovek323 and
ttuegel
GrahamcOfBorg
added
10.rebuild-darwin: 501+
Member
|
Well, it's perhaps no big deal, as it's darwin that's the significant bottleneck on our Hydra. If we had linux-specific patches that occasionally change and cause mass darwin rebuilds, that would be different. |
vcunat
approved these changes
Feb 24, 2019
Member
Author
|
My build isn't done yet, but no errors so far. |
Member
|
Our bigmac will surely be better for this stuff, and it was idling now anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
NOTE I only tested the bootstrap cmake at this point, but this might unblock staging-next.
Fixes #56244
/cc @FRidh @vcunat
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)