Skip to content

staging-next: another iteration#56200

Merged
FRidh merged 596 commits intomasterfrom
staging-next
Mar 1, 2019
Merged

staging-next: another iteration#56200
FRidh merged 596 commits intomasterfrom
staging-next

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Feb 22, 2019

This might be the last iteration before forking 19.03, so let me /cc @lheckemann.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 24, 2019
@dotlambda dotlambda mentioned this pull request Feb 24, 2019
10 tasks
CXXFLAGS = stdenv.lib.optionalString stdenv.cc.isClang "-std=c++11";

nativeBuildInputs = [
gdal # for gdal-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh Just wanted to let you know that I believe this is a situation where a package needs to be in nativeBuildInputs as well as buildInputs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes. gdal-config requires it to be in nativeBuildInputs, but we also build against it so also in buildInputs.

@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 25, 2019
@FRidh
Copy link
Member

FRidh commented Feb 25, 2019

Python failure of jupyter/nbconvert is transient.

@lheckemann
Copy link
Member

This won't magically be ready in the next hour, will it? :/ I guess we'll have to rebase it into the release branch after the fact. :(

@FRidh
Copy link
Member

FRidh commented Feb 25, 2019

I think this can go in. Aarch64 is currently broken, but that can be fixed up.

(cherry picked from commit 9c94d74)
From PR #56414.  Forward-picking from staging to staging-next,
as minor openssl bumps tend to be fairly breakage-free.
@FRidh
Copy link
Member

FRidh commented Feb 27, 2019

@vcunat @lheckemann how to proceed to get this into staging-19.03?

@FRidh FRidh merged commit fc4a8f6 into master Mar 1, 2019
@FRidh
Copy link
Member

FRidh commented Mar 1, 2019

I've merged staging-next into both master and staging-19.03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.