Skip to content

cc-wrapper: add libcxx for libcxxClang#54624

Merged
matthewbauer merged 1 commit intoNixOS:stagingfrom
matthewbauer:libcxx
Jan 27, 2019
Merged

cc-wrapper: add libcxx for libcxxClang#54624
matthewbauer merged 1 commit intoNixOS:stagingfrom
matthewbauer:libcxx

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Jan 26, 2019

clang needs to find headers + libraries for compiling with libc++. We
need to add a libcxx argument to cc-wrapper. This means you do not
have to pass in c++ headers directly.

This resolves the last case remaining of #30670. Darwin clang++ now
works properly.

Fixes #30670

@matthewbauer matthewbauer force-pushed the libcxx branch 2 times, most recently from 4eebb31 to ce17f99 Compare January 27, 2019 01:58
@matthewbauer
cc-wrapper: add libcxx for libcxxClang
77550df 
clang needs to find headers + libraries for compiling with libc++. We
need to add a libcxx argument to cc-wrapper. This means you do not
have to pass in c++ headers directly.

This resolves the last case remaining of NixOS#30670. Darwin clang++ now
works properly.

Fixes NixOS#30670
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 27, 2019
@matthewbauer matthewbauer changed the base branch from master to staging January 27, 2019 04:02
@GrahamcOfBorg GrahamcOfBorg added 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 27, 2019
@matthewbauer matthewbauer changed the base branch from staging to master January 27, 2019 05:02
@matthewbauer matthewbauer changed the base branch from master to staging January 27, 2019 05:03
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 27, 2019
@matthewbauer matthewbauer merged commit bb3683d into NixOS:staging Jan 27, 2019
@dtzWill
Copy link
Member

dtzWill commented Jan 27, 2019

Is this Darwin-only?

We previously had tests for this--were they failing? They seem to pass for me in my tree, FWIW.

I use libcxxStdenv for various things (including my system's nix) so I'm not sure what this is supposed to fix if it's not Darwin-only.

(regardless, is there a particular usage/scenario fixed by this? And should that be a test to ensure this works in the future?)

@matthewbauer
Copy link
Member Author

matthewbauer commented Jan 27, 2019

This makes clang++ work outside of a Nix derivation... It's a kind of specific use case but was often an issue. We provide it for g++, so we might as well make it work with clang.

@tex tex mentioned this pull request Jan 29, 2019
Closed
@matthewbauer matthewbauer deleted the libcxx branch February 22, 2019 04:17
@alex-ameen
Copy link
Contributor

alex-ameen commented Jul 6, 2020 •
edited
Loading

Is this Darwin-only?

We previously had tests for this--were they failing? They seem to pass for me in my tree, FWIW.

I use libcxxStdenv for various things (including my system's nix) so I'm not sure what this is supposed to fix if it's not Darwin-only.

(regardless, is there a particular usage/scenario fixed by this? And should that be a test to ensure this works in the future?)

I completely agree, why does this not work on NixOS systems as well?
I am pulling my hair out just trying to hack around on a clang-c example.

I love NixOS but it's times like this that I get really frustrated with it...

I'm not always in the mood to write up a whole shell.nix for a little throwaway example; nix-shell -p clang or nix-shell -p llvmPackages.libclang should "work out the box".

JFC I'm not criticizing the author, I'm asking why this behavior is only for Darwin?

@Ericson2314
Copy link
Member

Ericson2314 commented Jul 6, 2020 •
edited
Loading

It might be better since f3f7612

@Mic92
Copy link
Member

Mic92 commented Jul 6, 2020

Is this Darwin-only?
We previously had tests for this--were they failing? They seem to pass for me in my tree, FWIW.
I use libcxxStdenv for various things (including my system's nix) so I'm not sure what this is supposed to fix if it's not Darwin-only.
(regardless, is there a particular usage/scenario fixed by this? And should that be a test to ensure this works in the future?)

I completely agree, why does this not work on NixOS systems as well?
I am pulling my hair out just trying to hack around on a clang-c example.

I love NixOS but it's times like this that I get really frustrated with it...

I'm not always in the mood to write up a whole shell.nix for a little throwaway example; nix-shell -p clang or nix-shell -p llvmPackages.libclang should "work out the box".

JFC I'm not criticizing the author, I'm asking why this behavior is only for Darwin?

nix-shell -p clang would be nice to work until this happens you may find the following shell functions useful to improve your workflow: https://github.com/direnv/direnv/wiki/Nix#shell-function-to-quickly-setup-nix--direnv-in-a-new-project

@ghost ghost mentioned this pull request Nov 9, 2023
Merged
12 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@matthewbauer @dtzWill @alex-ameen @Ericson2314 @Mic92 @rrbutani @GrahamcOfBorg