Skip to content

efitools: init at 1.9.2#54471

Merged
grahamc merged 1 commit intoNixOS:masterfrom
grahamc:efitools
Jan 22, 2019
Merged

efitools: init at 1.9.2#54471
grahamc merged 1 commit intoNixOS:masterfrom
grahamc:efitools

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Jan 22, 2019

Motivation for this change

Packaged as part of #53901

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

samueldr
samueldr reviewed Jan 22, 2019
View reviewed changes
@grahamc
Copy link
Member Author

grahamc commented Jan 22, 2019

Fixed up!

symphorien
symphorien reviewed Jan 22, 2019
View reviewed changes
pkgs/tools/security/efitools/default.nix Outdated
Copy link
Member

@symphorien symphorien Jan 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help2man and probably perl should be nativeBuildInputs

Copy link
Member Author

@grahamc grahamc Jan 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up!

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 22, 2019
@grahamc grahamc mentioned this pull request Jan 22, 2019
Closed
@grahamc grahamc merged commit f3e2348 into NixOS:master Jan 22, 2019
@grahamc grahamc deleted the efitools branch January 22, 2019 15:42
@symphorien symphorien mentioned this pull request Jan 23, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@symphorien symphorien symphorien left review comments

+1 more reviewer

@samueldr samueldr samueldr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grahamc @samueldr @symphorien @GrahamcOfBorg