Skip to content

[WIP] Build nixpkgs with gcc 8 by default#53760

Merged
matthewbauer merged 64 commits intostagingfrom
gcc-8
Feb 7, 2019
Merged

[WIP] Build nixpkgs with gcc 8 by default#53760
matthewbauer merged 64 commits intostagingfrom
gcc-8

Conversation

@fpletz
Copy link
Member

@fpletz fpletz commented Jan 10, 2019 •
edited
Loading

This PR bumps gcc used in stdenv to version 8. The main motivation for this is the ability to add -fstack-clash-protection to our default hardening flags (#53753). This will be done in a separate PR.

I anticipate quite a few of broken packages because there are some new checks, i.e. for array bounds and format truncation.

There is also an old gcc8 branch which I noticed just now thanks to @Synthetica9. I'll cherry-pick changes from there.

Hydra Job: https://hydra.nixos.org/jobset/nixpkgs/gcc8
Newly failing builds with gcc8: https://hydra.nixos.org/eval/1500732?compare=staging-next

Current state: Most packages seem to build. clang segfaults currently. gcc fails on Darwin.

@fpletz fpletz added this to the 19.03 milestone Jan 10, 2019
@nixos-discourse

This comment has been minimized.

Sign in to view
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 10, 2019
Mic92
Mic92 reviewed Jan 10, 2019
View reviewed changes
Mic92
Mic92 reviewed Jan 10, 2019
View reviewed changes
@fpletz fpletz requested a review from matthewbauer as a code owner January 11, 2019 03:21
@GrahamcOfBorg GrahamcOfBorg added 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 8.has: package (new) This PR adds a new package labels Jan 11, 2019
@fpletz fpletz requested a review from FRidh as a code owner January 11, 2019 05:27
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 11, 2019
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. label Jan 11, 2019
@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up This PR removes packages or removes other cruft labels Jan 11, 2019
@edolstra
Copy link
Member

edolstra commented Jan 11, 2019

I see 172 commits, maybe you need to rebase this?

@vcunat
Copy link
Member

vcunat commented Jan 11, 2019

I believe it's mainly because it got master commits that are missing from staging at this point.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Jan 15, 2019
@fpletz
Copy link
Member Author

fpletz commented Jan 17, 2019

I've rebased this branch onto staging-next because there are some python packages failing on staging that prevent us to check for gcc8 build failures for lots of packages.

@matthewbauer matthewbauer modified the milestones: 19.03, 19.09 Feb 6, 2019
@matthewbauer
Copy link
Member

matthewbauer commented Feb 6, 2019

Let's aim for this right after the 19.03 branch off. We still have quite a few things in staging that I am wanting to prioritize.

@matthewbauer matthewbauer reopened this Feb 6, 2019
@matthewbauer
Copy link
Member

matthewbauer commented Feb 6, 2019

Sorry didn't mean to close it!

@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 6, 2019
@matthewbauer matthewbauer merged commit f959c99 into staging Feb 7, 2019
@vcunat vcunat deleted the gcc-8 branch February 9, 2019 07:50
@tobim tobim mentioned this pull request Jun 14, 2019
Closed
@vcunat
Copy link
Member

vcunat commented Jun 14, 2019

Why the hell was f959c99 detected as merged to staging? It certainly doesn't seem reachable ATM.

@vcunat vcunat restored the gcc-8 branch June 14, 2019 15:59
@vcunat vcunat mentioned this pull request Jun 14, 2019
Merged
@vcunat
Copy link
Member

vcunat commented Jun 14, 2019

Well, GitHub still thinks it's merged and thus won't let me reopen in-place. Instead I opened #63132 so we don't lose the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 left review comments

@jtojnar jtojnar jtojnar left review comments

@globin globin globin left review comments

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@FRidh FRidh Awaiting requested review from FRidh

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

19.09

Development

Successfully merging this pull request may close these issues.