Skip to content

nixos/systemd-udev-settle: don't restart on upgrades#53446

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:systemd-udev-settle
Jan 8, 2019
Merged

nixos/systemd-udev-settle: don't restart on upgrades#53446
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:systemd-udev-settle

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 5, 2019 •
edited
Loading

The idea is that we only need this target during boot,
however there is no point on restarting it on every upgrade.

This hopefully fixes #21954

Please let me test this for a while!

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos/systemd-udev-settle: don't restart on upgrades
0a2c8cc 
The idea is that we only need this target during boot,
however there is no point on restarting it on every upgrade.

This hopefully fixes NixOS#21954
@Mic92 Mic92 requested a review from infinisil as a code owner January 5, 2019 12:58
@Mic92 Mic92 mentioned this pull request Jan 5, 2019
Closed
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 5, 2019
@peterhoeg
Copy link
Member

peterhoeg commented Jan 7, 2019

While at it, how about adding a configuration setting for completely disabling udev-settle?

@Mic92 Mic92 merged commit ba9f589 into NixOS:master Jan 8, 2019
@Mic92 Mic92 deleted the systemd-udev-settle branch January 8, 2019 12:05
@Mic92
Copy link
Member Author

Mic92 commented Jan 8, 2019

@peterhoeg I would like to keep this out of scope of this pull-request.

@Mic92
Copy link
Member Author

Mic92 commented Jan 8, 2019

I think this change is safe to backport.

@Mic92 Mic92 mentioned this pull request Jan 8, 2019
Merged
10 tasks
@peterhoeg
Copy link
Member

peterhoeg commented Jan 8, 2019

Fair enough.

@lheckemann lheckemann mentioned this pull request Nov 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nixos-rebuild switch produces warnings about systemd-udev-settle service

3 participants

@Mic92 @peterhoeg @GrahamcOfBorg