Revert "zfs cannot be distributed. Disabling it in the isos."#51090
Merged
grahamc merged 1 commit intoNixOS:masterfrom Nov 29, 2018
Merged
Revert "zfs cannot be distributed. Disabling it in the isos."#51090grahamc merged 1 commit intoNixOS:masterfrom
grahamc merged 1 commit intoNixOS:masterfrom
Conversation
ZFS's popularity is growing, and not including it by default is a bit frustrating. On top of that, the base iso includes ZFS _anyway_ due to other packages depending upon it. I think we're in the clear to do this on the basis that Oracle probably doesn't care, it is probably fine (the SFLC agrees) and we're a small fish. If a copyright holder asks us to, we can definitely revert it again. This reverts commit 33d07c7.
grahamc
referenced
this pull request
Nov 26, 2018
It seems that it is a GPL violation to distribute zfs in the installation ISOs. https://sfconservancy.org/blog/2016/feb/25/zfs-and-linux/ If anyone knows the issue better and has a reason to reenable it legally, feel free to reenable it. I don't know much about it.
Member
Author
|
@armijnhemel says:
and we do distribute the source code via binary cache, and the build instructions by virtue of having nixpkgs in the image. |
GrahamcOfBorg
added
6.topic: nixos
vcunat
approved these changes
Nov 28, 2018
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
Risks vs. benefits ratio seems very favorable to me.
Member
|
I believe this is safe for 18.09, too. |
Member
Author
|
Backported in a0c7949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZFS's popularity is growing, and not including it by default is a
bit frustrating. On top of that, the base iso includes ZFS
anyway due to other packages depending upon it.
I think we're in the clear to do this on the basis that Oracle
probably doesn't care, it is probably fine (the SFLC agrees) and
we're a small fish. If a copyright holder asks us to, we can
definitely revert it again.
This reverts commit 33d07c7.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)