onnxruntime: 1.23.2 -> 1.24.4#501901
Conversation
4376b55 to
e73952e
Compare
e73952e to
f280d9f
Compare
40d981f to
3efb481
Compare
|
3efb481 to
b5e6acf
Compare
|
b5e6acf to
3725a34
Compare
onnxruntime 1.23.2 fails to compile on Darwin because protobuf 34 added [[nodiscard]] to SerializeToString and the nixpkgs protobuf34-nodiscard patch misses the test suite (graph_test.cc). Clang then turns the discarded returns into hard errors via -Werror. Fixed upstream in NixOS/nixpkgs#501901 (onnxruntime 1.24.4 with a complete patch) but that merge has not propagated to nixpkgs-unstable yet. Rather than backport the version bump or patch, inject -Wno-error=unused-result through NIX_CFLAGS_COMPILE. The override is version-gated so it becomes a no-op once nixpkgs advances past 1.24, at which point lib/onnxruntime-override.nix can be dropped. Applied to both direct (ck) and transitive (hermes-agent via faster-whisper) consumers. Fixes #3409
onnxruntime 1.23.2 fails to compile on Darwin because protobuf 34 added [[nodiscard]] to SerializeToString and the nixpkgs protobuf34-nodiscard patch misses the test suite (graph_test.cc). Clang then turns the discarded returns into hard errors via -Werror. Fixed upstream in NixOS/nixpkgs#501901 (onnxruntime 1.24.4 with a complete patch) but that merge has not propagated to nixpkgs-unstable yet. Rather than backport the version bump or patch, inject -Wno-error=unused-result through NIX_CFLAGS_COMPILE. The override is version-gated so it becomes a no-op once nixpkgs advances past 1.24, at which point lib/onnxruntime-override.nix can be dropped. Applied to both direct (ck) and transitive (hermes-agent via faster-whisper) consumers. Fixes #3409
nixpkgs now ships onnxruntime 1.24.4 (NixOS/nixpkgs#501901), which satisfies ort-sys 2.0.0-rc.12 requirements (API v24). Remove the temporary prebuilt binary overlay and update flake.lock to pick up the new version. Closes cjpais#1059
onnxruntime 1.23.2 fails to compile on Darwin because protobuf 34 added [[nodiscard]] to SerializeToString and the nixpkgs protobuf34-nodiscard patch misses the test suite (graph_test.cc). Clang then turns the discarded returns into hard errors via -Werror. Fixed upstream in NixOS/nixpkgs#501901 (onnxruntime 1.24.4 with a complete patch) but that merge has not propagated to nixpkgs-unstable yet. Rather than backport the version bump or patch, inject -Wno-error=unused-result through NIX_CFLAGS_COMPILE. The override is version-gated so it becomes a no-op once nixpkgs advances past 1.24, at which point lib/onnxruntime-override.nix can be dropped. Applied to both direct (ck) and transitive (hermes-agent via faster-whisper) consumers. Fixes #3409
nixpkgs-unstable now ships onnxruntime 1.24.4 (NixOS/nixpkgs#501901), so the Darwin -Wno-error=unused-result workaround for the incomplete protobuf34-nodiscard.patch in 1.23.2 is no longer needed. The override was already version-gated to be a no-op for >=1.24. Revert ck and hermes-agent to plain callPackage. Closes #3451
Things done
Diff: microsoft/onnxruntime@v1.23.2...v1.24.4
Changelog: https://github.com/microsoft/onnxruntime/releases/tag/v1.24.4
cc @puffnfresh @ck3d
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.