Closed
Conversation
nixpkgs-ci
bot
added
8.has: package (update)
giardb
force-pushed
the
bump(onnxruntime)/onnxruntime-1.24.1
branch
from
0ee6b6c to
94a7f88
Compare
xilec
added a commit
to xilec/Handy
that referenced
this pull request
Mar 16, 2026
ort 2.0.0-rc.12 enables API v24 by default, but nixpkgs only ships onnxruntime 1.23.2 (API v23), causing a runtime panic on model load. Override onnxruntime to 1.24.2 via overlay, bumping onnx to v1.20.1 and abseil-cpp to 202508 as required by the new version. This overlay should be removed once nixpkgs merges onnxruntime ≥ 1.24: NixOS/nixpkgs#499389
3 tasks
xilec
added a commit
to xilec/Handy
that referenced
this pull request
Mar 16, 2026
ort 2.0.0-rc.12 enables API v24 by default, but nixpkgs only ships onnxruntime 1.23.2 (API v23), causing a runtime panic on model load. Use Microsoft's prebuilt binaries for onnxruntime 1.24.2 via overlay, patched with autoPatchelfHook for NixOS compatibility. This overlay should be removed once nixpkgs merges onnxruntime ≥ 1.24: NixOS/nixpkgs#499389
cjpais
pushed a commit
to cjpais/Handy
that referenced
this pull request
Mar 16, 2026
ort 2.0.0-rc.12 enables API v24 by default, but nixpkgs only ships onnxruntime 1.23.2 (API v23), causing a runtime panic on model load. Use Microsoft's prebuilt binaries for onnxruntime 1.24.2 via overlay, patched with autoPatchelfHook for NixOS compatibility. This overlay should be removed once nixpkgs merges onnxruntime ≥ 1.24: NixOS/nixpkgs#499389
This was referenced Mar 16, 2026
cjpais
added a commit
to cjpais/Handy
that referenced
this pull request
Mar 19, 2026
* test build for 0.16.0 * macos 10.15? * format * shorter dir for build on windows? * Update build.yml * move * Update build.yml * long path support * clang * try * try * move to ort rc12 * use ms prebuilt? * use lower version for 1.23.1 * download my prebuilt * Update build.yml * Update build.yml * fix? * fix(nix): use dynamic linking for ort-sys 2.0.0-rc.12 ort-sys rc.12 removed pkg-config support; without ORT_PREFER_DYNAMIC_LINK it defaults to static linking against ORT_LIB_LOCATION, which fails because nixpkgs only provides shared libraries (.so). * fix(nix): override onnxruntime to 1.24.2 for ort-sys rc.12 compatibility ort 2.0.0-rc.12 enables API v24 by default, but nixpkgs only ships onnxruntime 1.23.2 (API v23), causing a runtime panic on model load. Use Microsoft's prebuilt binaries for onnxruntime 1.24.2 via overlay, patched with autoPatchelfHook for NixOS compatibility. This overlay should be removed once nixpkgs merges onnxruntime ≥ 1.24: NixOS/nixpkgs#499389 * updated deps for whisper * fix(nix): sync devShell with packages for ort-sys rc.12 compatibility - Extract shared definitions (commonNativeDeps, gstPlugins, commonEnv, onnxruntimeOverlay) to avoid duplication between packages and devShells - Add onnxruntime 1.24.2 overlay to devShell (was only in packages) - Add BINDGEN_EXTRA_CLANG_ARGS to devShell so bindgen can find stdio.h and generate correct vulkan bindings for whisper-rs-sys - Add ORT_LIB_LOCATION and ORT_PREFER_DYNAMIC_LINK to devShell - Replace libappindicator with libayatana-appindicator in devShell - Add onnxruntime and vulkan-loader to devShell LD_LIBRARY_PATH * fix missing lib in the handy blob dl * scope lib verification * dont run bun2nix on windows --------- Co-authored-by: Evgeny <[email protected]>
Contributor
|
#501901 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
onnxruntimefrom 1.23.2 to 1.24.3. See https://github.com/microsoft/onnxruntime/releases/tag/v1.24.3.onnx,cutlass,abseil-cpp, etc.) with upstreamcmake/deps.txtfor v1.24.3.absl::low_level_hashas an alias forabsl::hash, matching the new abseil-cpp LTS layout and fixing the link failure.EDIT: I updated this PR from 1.24.1 to 1.24.3. Both 1.24.2 and 1.24.3 are patch releases for the 1.24 series of ONNX Runtime, so moving directly to 1.24.3 keeps us on the latest stable patch without changing the underlying major/minor version.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage.nixpkgs-review --package onnxruntimeonx86_64-linuxbuilt:onnxruntimeonnxruntime.debugonnxruntime.devonnxruntime.dist./result/bin/.import onnxruntime; onnxruntime.__version__ == "1.24.3"onnxruntime.datasets.mul_1.onnxand ran inference viaInferenceSession(..., providers=["CPUExecutionProvider"])onx = np.ones((3, 2), dtype=np.float32).