Skip to content

Marry meta.broken with meta.problems#494416

Open
infinisil wants to merge 2 commits intoNixOS:masterfrom
tweag:rfc127-broken
Open

Marry meta.broken with meta.problems#494416
infinisil wants to merge 2 commits intoNixOS:masterfrom
tweag:rfc127-broken

Conversation

@infinisil
Copy link
Member

  • Make meta.broken use meta.problems.broken underneath.
  • Deprecate config.allowBrokenPredicate in favor of config.problem.handlers

Follow-up on #478539

Things done

  • Added tests for both historical and new behavior of meta.broken
  • Updated Nixpkgs docs
  • Added a deprecation warning to config.allowBrokenPredicate that only triggers after meta.problems is supported in all stable releases

### `broken` {#var-meta-broken}

If set to `true`, the package is marked as "broken", meaning that it won’t show up in [search.nixos.org](https://search.nixos.org/packages), and cannot be built or installed unless the environment variable [`NIXPKGS_ALLOW_BROKEN`](#opt-allowBroken) is set.
If set to `true`, the package is marked as "broken", meaning that it won’t show up in [search.nixos.org](https://search.nixos.org/packages), and cannot be built or installed unless [explicitly allowing it](#sec-allow-broken).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If set to `true`, the package is marked as "broken", meaning that it won’t show up in [search.nixos.org](https://search.nixos.org/packages), and cannot be built or installed unless [explicitly allowing it](#sec-allow-broken).
If set to `true`, the package is marked as "broken", meaning that it won’t show up in [search.nixos.org](https://search.nixos.org/packages), and cannot be built or installed unless [explicitly allowed](#sec-allow-broken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants