qt5: simplify package functions' definitions and calls#492070
Merged
doronbehar merged 2 commits intoNixOS:masterfrom Feb 20, 2026
Merged
qt5: simplify package functions' definitions and calls#492070doronbehar merged 2 commits intoNixOS:masterfrom
doronbehar merged 2 commits intoNixOS:masterfrom
Conversation
added 2 commits
February 19, 2026 13:48
Rely on callPackage whenever possible.
nixpkgs-ci
bot
requested review from
K900,
NickCao,
SuperSandro2000 and
ttuegel
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
SuperSandro2000
approved these changes
Feb 20, 2026
qweered
approved these changes
Feb 20, 2026
nixpkgs-ci
bot
added
the
12.approvals: 2
Contributor
Author
|
Thanks for your review! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Cherry picked from:
Since there are no rebuilds, the merge should be easy.
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.