Open
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Sigmanificient
requested changes
Feb 10, 2026
pkgs/by-name/cm/cmtk/package.nix
Outdated
| # removed in cmake 4 (EXPORT_LIBRARY_DEPENDENCIES, cmake_minimum_required < 3.5). | ||
| # Use CMAKE_POLICY_VERSION_MINIMUM to maintain compatibility. | ||
| # https://github.com/NixOS/nixpkgs/issues/445447 | ||
| (lib.cmakeFeature "CMAKE_POLICY_VERSION_MINIMUM" "3.5") |
Member
There was a problem hiding this comment.
As stated from the tracking issues, we should set 3.10 to have more room for the future
EXPORT_LIBRARY_DEPENDENCIES was removed in cmake 4 (CMP0033). Remove the call and related install command since cmtk is a standalone tool that is not consumed as a cmake dependency. Also set CMAKE_POLICY_VERSION_MINIMUM=3.5 to handle cmake_minimum_required(VERSION 2.8.12) in upstream CMakeLists.txt. Fixes: NixOS#445447 Co-Authored-By: Claude Opus 4.6 <[email protected]>
colonelpanic8
force-pushed
the
cmtk-cmake4
branch
from
ebdf0b2 to
99d2430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXPORT_LIBRARY_DEPENDENCIEScall (removed in cmake 4, CMP0033) and its related install command. cmtk is a standalone tool, not consumed as a cmake dependency by other packages.CMAKE_POLICY_VERSION_MINIMUM=3.5to handlecmake_minimum_required(VERSION 2.8.12)in upstream CMakeLists.txtThis is a simpler alternative to draft PR #455098 which used a 267-line patch to modernize the export system. Since cmtk upstream is abandoned (last release 2016), removing the unused export is more appropriate than modernizing it.
Fixes #445447 (last remaining unchecked item)
Test plan
nix-build -A cmtksucceedscmtk registration --helpworksnixfmtpasses🤖 Generated with Claude Code