First class team reviews (try #2)#487955
Merged
infinisil merged 2 commits intoNixOS:masterfrom Feb 7, 2026
Merged
Conversation
Co-Authored-By: Alexander Bantyev <[email protected]>
This was referenced Feb 7, 2026
infinisil
force-pushed
the
first-class-team-reviews
branch
from
7d8a337 to
4c7e214
Compare
nixpkgs-ci
bot
requested review from
Artturin,
Ericson2314,
MattSturgeon,
Mic92,
RossComputerGuy,
adisbladis,
emilazy,
mdaniels5757,
philiptaron,
reckenrode and
zowoq
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
kashw2
reviewed
Feb 7, 2026
Member
Author
|
Merging now, am available to revert or fix right away if it doesn't work |
infinisil
force-pushed
the
first-class-team-reviews
branch
from
4c7e214 to
71e7047
Compare
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
Member
Author
|
It does fail again, looking into it: https://github.com/NixOS/nixpkgs/actions/runs/21782693200/job/62849125010 |
2 tasks
Member
Author
|
It works! #479442 (comment) |
Contributor
|
Congratulations! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #456481, but with an additional commit to fix the problem that caused the need for a revert: #487507
I now tested it "in production" by manually changing the code locally to pretend that I'd have to be requested for a PR, which worked: #471082 (comment)
Cc @philiptaron, @MattSturgeon, @mdaniels5757, @zowoq