Conversation
Rely on callPackage whenever possible.
It never worked and it's just an attempt to duplicate the logic from qmake (i.e. QMAKEPATH -> QMAKEMODULES translation) that qmake does all by itself.
hyphen's sources in tarbals are identical, and the version from pkgs properly supports cross compilation.
This reverts commit 6e27bc9.
propagate less of them
…qmakeFlags but don't use __structuredAttrs
|
Also there's a backported CVE patch for |
| @@ -236,6 +230,18 @@ let | |||
| ./qtwebkit.patch | |||
| ./qtwebkit-icu68.patch | |||
| ./qtwebkit-cstdint.patch | |||
| (fetchpatch { | |||
| url = "https://src.fedoraproject.org/rpms/qt5-qtwebkit/raw/84f3c61c46bce99bfbd70d8c202e022d62f2ea9a/f/qtwebkit-icu76.patch"; | |||
| sha256 = "sha256-Z+ot7R5Dy+F08FbcXzN4MB2ttxLg0I0P8uVErpbFiu4="; | |||
There was a problem hiding this comment.
| sha256 = "sha256-Z+ot7R5Dy+F08FbcXzN4MB2ttxLg0I0P8uVErpbFiu4="; | |
| hash = "sha256-Z+ot7R5Dy+F08FbcXzN4MB2ttxLg0I0P8uVErpbFiu4="; |
|
@eryngion well done for all the work! I have a few comments regarding the commit messages. I'd personally apply the following rebase on the commit log: I also have a question: How come |
I was wondering about something along those lines. So, In native builds includes look like this: But in cross builds I get this: Looks like And the bootstrap build is forced by cross compilation: NB: this is not what I'm doing with And maybe we should try and disable this |
|
Re: splits and merges. I'm also removing a couple of unused dependencies in the big |
The logic behind the commit separation suggestions is as under discussion here: The general rule of thumb I'm following is: Changes that are:
Should be split to different commits. In this case, the Nixpkgs tree is fully using GCC 15 now, and there is no point in reverting a commit that makes the build fail. However I did not notice the qtwebengine also mixes changes that are not necessarily related to each other, so now that you are saying that, I think they too should be decoupled, to:
TBH I haven't managed to follow you there. I trust you have made the sensible changes, but maybe it would have been nice to explain it better in the commit message. |
|
@eryngion would you like me to help you with this rebase? |
|
Err, if you want a quicker merge, split into different PRs is more acceptable |
|
Here are the 2 first commits of this PR, targeting Of course @eryngion is the committer there :). |
|
The Here is a Afterwards, the only remaining commit is: Afterwards I'll try to open separate PRs for changes from #267311 . |
These are various fixes, improvements, and cleanups that I've accumulated over the past 2+ years of trying to keep my out-of-tree cross compilation changes working. Most of these commits are applicable to native builds too and nothing here depends on the scary cross changes.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.