Skip to content

frescobaldi: 3.3.0 -> 4.0.4, switch to qt6#487224

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
LordGrimmauld:frescobaldi-qt6
Feb 11, 2026
Merged

frescobaldi: 3.3.0 -> 4.0.4, switch to qt6#487224
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
LordGrimmauld:frescobaldi-qt6

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Feb 5, 2026

Updates and unbreaks frescobaldi. This includes a migration to qt6, which removes yet another dependency on qt5 webengine.
Part of #480196

image

Runs and can display the music sheet PDFs.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested review from LunNova and camillemndn February 5, 2026 13:03
@nixpkgs-ci nixpkgs-ci bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 5, 2026
@LordGrimmauld LordGrimmauld mentioned this pull request Feb 5, 2026
Draft
27 tasks
LunNova
LunNova approved these changes Feb 5, 2026
View reviewed changes
Copy link
Member

@LunNova LunNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyqt looks good, frescobaldi changes make sense and the app opens. I don't know/use it to properly test but it's been vulnerable for ages so probably an improvement.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 5, 2026
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Feb 5, 2026

I used frescobaldi quite a bit a few years ago, and in terms of functionality i don't see immediate issues. It is basically just a split editor for lilypond, using webengine to display PDFs, and that does work. I am fairly confident in frescobaldi itself being fine, and was more worried about the potential cost of adding webengine into pyqt6.

@LunNova
Copy link
Member

LunNova commented Feb 5, 2026

Could default it false and override on use in frescobaldi/package.nix, iirc that's allowed with frescobaldi not being in the python-packages set but not very confident on that.

Doesn't feel necessary to me though, could see if anyone else has input there.

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Feb 11, 2026
Merged via the queue into NixOS:master with commit a6d92fa Feb 11, 2026
36 of 38 checks passed
@marcin-serwin marcin-serwin mentioned this pull request Feb 18, 2026
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@camillemndn camillemndn Awaiting requested review from camillemndn

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LordGrimmauld @LunNova @SuperSandro2000