Skip to content

qutebrowser-qt5: drop#487217

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
LordGrimmauld:qt5-browsers
Feb 5, 2026
Merged

qutebrowser-qt5: drop#487217
dotlambda merged 1 commit intoNixOS:masterfrom
LordGrimmauld:qt5-browsers

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Feb 5, 2026

drops browsers doing qt5 webengine
part of #480196
morph is done in #467662, ideally. That one is not yet ready.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@LordGrimmauld LordGrimmauld changed the title Qt5 browsers webmacs, qutebrowser: drop Feb 5, 2026
@LordGrimmauld LordGrimmauld changed the title webmacs, qutebrowser: drop webmacs, qutebrowser-qt5: drop Feb 5, 2026
@nixpkgs-ci nixpkgs-ci bot requested review from dotlambda, jacg and rnhmjoj February 5, 2026 12:42
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 5, 2026
@Sigmanificient
Copy link
Member

Sigmanificient commented Feb 5, 2026

there is also:

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 5, 2026
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Feb 5, 2026

Ah oops, missed that. I had posted about it in security discussions on matrix, but i guess i can just merge the other webmacs PR and make this only qute browser

@LordGrimmauld LordGrimmauld changed the title webmacs, qutebrowser-qt5: drop qutebrowser-qt5: drop Feb 5, 2026
@dotlambda dotlambda enabled auto-merge February 5, 2026 15:52
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 5, 2026
@dotlambda dotlambda added this pull request to the merge queue Feb 5, 2026
Merged via the queue into NixOS:master with commit e0269e5 Feb 5, 2026
30 of 33 checks passed
@LordGrimmauld LordGrimmauld mentioned this pull request Feb 5, 2026
Draft
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

@jacg jacg Awaiting requested review from jacg

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LordGrimmauld @Sigmanificient @LunNova @rnhmjoj @dotlambda