Merged
Conversation
GrahamcOfBorg
added
8.has: clean-up
|
Success on aarch64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
lsix
suggested changes
Oct 19, 2018
Member
lsix
left a comment
lsix
left a comment
There was a problem hiding this comment.
I have not been really looking at it for the moment, but do we want to add an option in the service to enable the new JIT capabilities for pg-11 (I think it is only a runtime dependency to the LLVM infrastructure, but I have to check)?
As far as I can see, this breaks the nixos/tests/postgis.nix test (which tests postgresql10 + postgis, so it uses the old postgresql100 attribute name). Can you update this as well ? Ideally, it should test all versions of postgresql with postgis, but only bumping to postgres11 should be fine.
Member
|
(and thanks for the PR of course!) |
Member
|
JIT support requires a configure time flag: https://www.postgresql.org/docs/11/static/install-procedure.html#CONFIGURE-WITH-LLVM I am not saying we should set that up now, just wondering if we should introduce an option to support it. |
Member
Author
|
I'd keep ```postgresql100```
But Postgresql100 points to 10.5! I don't think that's very good naming at all.
If you insist on renaming, there are 2 things to consider
* old name is to be added to ```aliases.nix``` in order not to break user code which uses the old name.
Happy to do this.
* why not to rename to ```postgresql_10``` ? ```small-L``` following by ```1``` is not very readable: 
Because that would be inconsistent with the rest of nixpkgs. This is less of an issue with nixpkgs and more of an issue with your choice of font!
|
GrahamcOfBorg
added
the
6.topic: nixos
Member
Author
On further investigation I note that there are packages that separate name and version with an underscore, eg ruby_2_4. But most seem to be in the |
GrahamcOfBorg
added
10.rebuild-darwin: 101-500
|
Success on x86_64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: postgresql10, postgresql11 Partial log (click to expand)
|
Member
Author
Agreed. I'll fix those and add aliases. |
GrahamcOfBorg
added
8.has: documentation
Member
Author
|
Done! Had to rebase to avoid a conflict in the release notes. |
GrahamcOfBorg
added
8.has: changelog
Member
|
Looks like you have re-introduced the JIT related commit (the one that compiles everything with clang instead of gcc) |
|
Success on aarch64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
Member
Author
|
Ah whoops, so I had. Fixed. |
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
|
Success on aarch64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
lsix
reviewed
Oct 30, 2018
Member
There was a problem hiding this comment.
Even if I see that this changes nothing, I think it is better for tractability to leave this line unchanged (at least in the context of postgresql updates) (I guess you have automated white space stripping in your text editor).
|
Success on aarch64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
Member
|
Good for me, merged. Thanks @alyssais for the work, and sorry it took so long. |
|
Success on x86_64-linux (full log) Attempted: postgresql_11 Partial log (click to expand)
|
13 tasks
Member
|
JIT support will be handled by #38698 once it's merged, JFYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've renamed
postgres100topostgres10as part of this change, because100implies Nix packages multiple versions of Postgresql 10, which it does not. This is similar to how we do things for eg OpenSSL (#46524).Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)