patch for wreq 0.2 to work with lens 4.5#4856
Conversation
|
So we're just waiting for relrod/wreq@9a91d57 right? |
patch for wreq 0.2 to work with lens 4.5
|
Please don't commit a patch to the Nixpkgs repository that's available for download. Instead, use |
|
My bad for merging this in that case (even if I did make a note to myself to remove the patch later). |
|
@peti OTOH patch filed have a tendency to disappear upstream and then the build fails. For cleaning files, why not write a script that finds files that are not referenced elsewhere in the tree? |
|
@wmertens, I am not aware of any script that finds unreferenced patches in Nixpkgs. If we had one, then adding patches to the Git repository would probably be the lesser evil, but since we do not, I'd rather update a patch URL than clutter the repository with stuff that's not needed any more after a while -- particularly when it concerns patch that are expected to be come obsolete within a couple of days. |
until wreq is fixed upstream