Skip to content

patch for wreq 0.2 to work with lens 4.5#4856

Merged
Fuuzetsu merged 1 commit intomasterfrom
unknown repository
Nov 7, 2014
Merged

patch for wreq 0.2 to work with lens 4.5#4856
Fuuzetsu merged 1 commit intomasterfrom
unknown repository

Conversation

@bflyblue
Copy link
Contributor

@bflyblue bflyblue commented Nov 6, 2014

until wreq is fixed upstream

@Fuuzetsu
Copy link
Member

Fuuzetsu commented Nov 7, 2014

So we're just waiting for relrod/wreq@9a91d57 right?

Fuuzetsu added a commit that referenced this pull request Nov 7, 2014
patch for wreq 0.2 to work with lens 4.5
@Fuuzetsu Fuuzetsu merged commit 4aff88c into NixOS:master Nov 7, 2014
@peti
Copy link
Member

peti commented Nov 7, 2014

Please don't commit a patch to the Nixpkgs repository that's available for download. Instead, use fetchpatch or fetchurl to retrieve the patch from Github. These patch files have a tendency to lie around in the directory tree even after they're no longer used.

@Fuuzetsu
Copy link
Member

Fuuzetsu commented Nov 7, 2014

My bad for merging this in that case (even if I did make a note to myself to remove the patch later).

@bflyblue bflyblue deleted the wreq-lens45 branch November 7, 2014 15:14
@wmertens
Copy link
Contributor

@peti OTOH patch filed have a tendency to disappear upstream and then the build fails.

For cleaning files, why not write a script that finds files that are not referenced elsewhere in the tree?

@peti
Copy link
Member

peti commented Nov 10, 2014

@wmertens, I am not aware of any script that finds unreferenced patches in Nixpkgs. If we had one, then adding patches to the Git repository would probably be the lesser evil, but since we do not, I'd rather update a patch URL than clutter the repository with stuff that's not needed any more after a while -- particularly when it concerns patch that are expected to be come obsolete within a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants