Skip to content

various: migrate go modules to finalAttrs #1#484479

Merged
Sigmanificient merged 13 commits intoNixOS:masterfrom
guylamar2006:gomodules-finalattrs-1
Feb 12, 2026
Merged

various: migrate go modules to finalAttrs #1#484479
Sigmanificient merged 13 commits intoNixOS:masterfrom
guylamar2006:gomodules-finalattrs-1

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Jan 27, 2026 •
edited
Loading

migrate go modules to finalAttrs pattern

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 27, 2026
@guylamar2006
Copy link
Contributor Author

guylamar2006 commented Jan 27, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 484479
Commit: 95217879b693dfdcad0d7c04b6ac716f07985ca5 (subsequent changes)
Merge: ea9393bfa098ba8cbb88b21c6d1e0915423e654a

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/21410869003

x86_64-linux

✅ No rebuilds

aarch64-linux

✅ No rebuilds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@guylamar2006 guylamar2006 force-pushed the gomodules-finalattrs-1 branch from 9521787 to 2bf900a Compare January 27, 2026 19:34
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 27, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 27, 2026
@guylamar2006 guylamar2006 force-pushed the gomodules-finalattrs-1 branch 2 times, most recently from 22f8b66 to f7520fd Compare January 31, 2026 14:29
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 31, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 2.status: merge conflict This PR has merge conflicts with the target branch and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 31, 2026
@guylamar2006 guylamar2006 force-pushed the gomodules-finalattrs-1 branch from f7520fd to a52243f Compare February 7, 2026 16:57
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 7, 2026
@guylamar2006 guylamar2006 force-pushed the gomodules-finalattrs-1 branch from a52243f to 62cb186 Compare February 7, 2026 17:04
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 10, 2026
@guylamar2006 guylamar2006 force-pushed the gomodules-finalattrs-1 branch from 62cb186 to e5cafe3 Compare February 12, 2026 14:28
@Sigmanificient Sigmanificient added this pull request to the merge queue Feb 12, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 12, 2026
Merged via the queue into NixOS:master with commit a8fd8c3 Feb 12, 2026
30 checks passed
@guylamar2006 guylamar2006 deleted the gomodules-finalattrs-1 branch February 12, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

+1 more reviewer

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guylamar2006 @qweered @Sigmanificient