Skip to content

tree-wide: use allowUnfreePackages where applicable#484367

Merged
bjornfor merged 1 commit intoNixOS:staging-nixosfrom
yuyuyureka:allow-unfree-packages
Jan 28, 2026
Merged

tree-wide: use allowUnfreePackages where applicable#484367
bjornfor merged 1 commit intoNixOS:staging-nixosfrom
yuyuyureka:allow-unfree-packages

Conversation

@yuyuyureka
Copy link
Contributor

@yuyuyureka yuyuyureka commented Jan 27, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@yuyuyureka yuyuyureka mentioned this pull request Jan 27, 2026
Merged
13 tasks
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@yuyuyureka yuyuyureka changed the base branch from master to staging-nixos January 27, 2026 12:10
@nixpkgs-ci nixpkgs-ci bot closed this Jan 27, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Jan 27, 2026
@yuyuyureka yuyuyureka force-pushed the allow-unfree-packages branch from 8016e1d to 2141b99 Compare January 27, 2026 12:10
@nixpkgs-ci nixpkgs-ci bot requested review from jtojnar and toonn January 27, 2026 12:19
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels 6.topic: k3s Kubernates distribution (https://k3s.io/) labels Jan 27, 2026
toonn
toonn approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 27, 2026
@bjornfor
Copy link
Contributor

bjornfor commented Jan 28, 2026

What is the "staging-nixos" branch? I've never heard of it. I was planning to merge, but then stopped due to the target branch.

@yuyuyureka
Copy link
Contributor Author

yuyuyureka commented Jan 28, 2026

staging accumulates changes which rebuild a lot of packages.
Similarly, staging-nixos accumulates changes which rebuild all NixOS tests, since rebuilds of the NixOS tests on the master branch were increasingly causing a lot of load on Hydra.

@bjornfor
Copy link
Contributor

bjornfor commented Jan 28, 2026

Ok, thanks! I see it's mentioned in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md now.

@bjornfor bjornfor added this pull request to the merge queue Jan 28, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 28, 2026
Merged via the queue into NixOS:staging-nixos with commit 2df1afb Jan 28, 2026
40 of 42 checks passed
@yuyuyureka yuyuyureka deleted the allow-unfree-packages branch January 29, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bjornfor bjornfor bjornfor approved these changes

@toonn toonn toonn approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

6.topic: hardware Drivers, Firmware and Kernels 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuyuyureka @bjornfor @toonn