Skip to content

Comments

various: migrate ocaml packages to finalAttrs pattern #2#482503

Merged
ulrikstrid merged 81 commits intoNixOS:masterfrom
guylamar2006:migrate-ocaml-packages-2
Feb 13, 2026
Merged

various: migrate ocaml packages to finalAttrs pattern #2#482503
ulrikstrid merged 81 commits intoNixOS:masterfrom
guylamar2006:migrate-ocaml-packages-2

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Jan 22, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@guylamar2006 guylamar2006 changed the title various: migrate ocaml packages to finalAttrs pattern various: migrate ocaml packages to finalAttrs pattern #2 Jan 22, 2026
@nixpkgs-ci nixpkgs-ci bot requested a review from ulrikstrid January 22, 2026 01:36
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Jan 22, 2026
@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 482503
Commit: 20469e141930c0cdcc82320b0aec2d3c271c1121 (subsequent changes)
Merge: 9b1ec789de120c618bd74a59eea61285d68e2952

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/21232565352


x86_64-linux

No rebuilds


aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 22, 2026
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 30, 2026
@guylamar2006 guylamar2006 force-pushed the migrate-ocaml-packages-2 branch from 20469e1 to 2dd1ea0 Compare January 31, 2026 14:42
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 31, 2026
Copy link
Member

@ulrikstrid ulrikstrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be no changes in output from what I can tell

@ulrikstrid ulrikstrid added this pull request to the merge queue Feb 13, 2026
Merged via the queue into NixOS:master with commit e4660f3 Feb 13, 2026
27 checks passed
@guylamar2006 guylamar2006 deleted the migrate-ocaml-packages-2 branch February 13, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants