Skip to content

various: migrate ocaml packages to finalAttrs pattern #1#482440

Merged
Sigmanificient merged 49 commits intoNixOS:masterfrom
guylamar2006:migrate-ocaml-packages-1
Jan 21, 2026
Merged

various: migrate ocaml packages to finalAttrs pattern #1#482440
Sigmanificient merged 49 commits intoNixOS:masterfrom
guylamar2006:migrate-ocaml-packages-1

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Jan 21, 2026

Migrate ocaml packages from rec to finalAttrs pattern

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from ulrikstrid January 21, 2026 22:10
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Jan 21, 2026
@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 482440
Commit: e7130e87882f273951fef15bbca14d13c2418d10 (subsequent changes)
Merge: 56322e54f00ab95559b1704c1846fd9df8e69b17

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/21227380915


x86_64-linux

No rebuilds


aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

Copy link
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 21, 2026
@Sigmanificient
Copy link
Member

@guylamar2006 all your commits are marked as unverified, is this normal?

@DieracDelta
Copy link
Member

DieracDelta commented Jan 21, 2026

srcbot: Full Evaluation Results for PR #482440

Status: 1/1 packages passed, 0 failed

1 packages passed
Package Steps Built
nixpkgs-manual package

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 21, 2026
Copy link
Member

@DieracDelta DieracDelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, it looks like none of the drvPaths changed. So no rebuilds are needed. LGTM!

@guylamar2006 guylamar2006 force-pushed the migrate-ocaml-packages-1 branch 2 times, most recently from 4c59d80 to 2533b95 Compare January 21, 2026 23:01
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jan 21, 2026
@guylamar2006 guylamar2006 force-pushed the migrate-ocaml-packages-1 branch from 2533b95 to 35d2d20 Compare January 21, 2026 23:07
@guylamar2006 guylamar2006 force-pushed the migrate-ocaml-packages-1 branch from 35d2d20 to 8543c7c Compare January 21, 2026 23:22
@guylamar2006
Copy link
Contributor Author

@Sigmanificient I generated a new GPG key since I reinstalled my OS, I got it fixed.

@Sigmanificient Sigmanificient added this pull request to the merge queue Jan 21, 2026
Merged via the queue into NixOS:master with commit bc010e1 Jan 21, 2026
25 checks passed
@guylamar2006 guylamar2006 deleted the migrate-ocaml-packages-1 branch January 21, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants