Skip to content

overridePythonAttrs: support extension-style newArgs (finalAttrs: args: { })#479258

Draft
ShamrockLee wants to merge 5 commits intoNixOS:masterfrom
ShamrockLee:build-python-overridePythonAttrs-finalAttrs
Draft

overridePythonAttrs: support extension-style newArgs (finalAttrs: args: { })#479258
ShamrockLee wants to merge 5 commits intoNixOS:masterfrom
ShamrockLee:build-python-overridePythonAttrs-finalAttrs

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Jan 12, 2026 •
edited
Loading

Fixes #258246

Depends on PR #477208

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

ShamrockLee and others added 5 commits January 6, 2026 04:33
@ShamrockLee
buildPython*: overrideStdenvCompat: abstract warning
2002d3e
@ShamrockLee
buildPython*: overrideStdenvCompat: lower warnings down to the stdenv…
15a70c8 
… override value

If Nix supports lazy attribute names in the future,
this change will make `<python package>.override` warning-free
and make such warning (or future throw) remediateable
via another override.
@ShamrockLee @MattSturgeon
buildPython*: extend overrideStdenvCompat to fixed-point arguments
22453e0 
with `passthru.__stdenvPythonCompat`

Co-authored-by: Matt Sturgeon <[email protected]>
@ShamrockLee
tests.overriding: add overridePythonAttrs-plain
6e1241f
@ShamrockLee
overridePythonAttrs: support extension-style newArgs
7321a9e 
Allow overridePythonAttrs to take `finalAttrs: args: { }`.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 12, 2026
@ShamrockLee ShamrockLee mentioned this pull request Jan 12, 2026
Open
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python: overridePythonAttrs should support final: prev: style overrides

1 participant

@ShamrockLee