Skip to content

haskell.compiler.ghc966DebianBinary: fix evaling pname#478128

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:ghc966-eval
Jan 9, 2026
Merged

haskell.compiler.ghc966DebianBinary: fix evaling pname#478128
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:ghc966-eval

Conversation

@jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Jan 8, 2026

pname needs to always be evaluable so that our package index can be correctly generatedw

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@jopejoe1 jopejoe1 mentioned this pull request Jan 8, 2026
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jan 8, 2026
@OPNA2608
Copy link
Contributor

OPNA2608 commented Jan 8, 2026

(Inviting myself ig, since CI didn't want to request my review)

Could prolly be written so variantSuffix is included only when a deb is used... But might make sense to just drop variantSuffix in general, since it's currently empty and only inherited from more normal GHC bins?

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 9, 2026

(Inviting myself ig, since CI didn't want to request my review)

CI will never request a review for you, because changes to this derivation won't cause any rebuilds on the 4 platforms eval'd in CI. It does ping the haskell team members via codeowners. To receive maintainer pings, you should probably add a codeowner entry for this file for you instead.

wolfgangwalther
wolfgangwalther approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle, but let's remove the now unused variantSuffix, too.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 9, 2026
@OPNA2608 OPNA2608 mentioned this pull request Jan 9, 2026
Merged
13 tasks
@OPNA2608
Copy link
Contributor

OPNA2608 commented Jan 9, 2026 •
edited
Loading

To receive maintainer pings, you should probably add a codeowner entry for this file for you instead.

Oki: #478378

Also noticing that this doesn't build anymore, because Debian finally bumped their GHC to 9.10.3, and debian-ports doesn't seem to retain any old versions on there… Will add a backup src for now, and make a PR to bump to the new version when my hardware is free again.

@OPNA2608 OPNA2608 mentioned this pull request Jan 9, 2026
Merged
13 tasks
@jopejoe1
haskell.compiler.ghc966DebianBinary: fix evaling pname
638a2be 
pname needs to always be evaluable so that our package index can be correctly generatedw
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Jan 9, 2026
Merged via the queue into NixOS:master with commit 5635b03 Jan 9, 2026
27 of 31 checks passed
@jopejoe1 jopejoe1 deleted the ghc966-eval branch January 9, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jopejoe1 @OPNA2608 @wolfgangwalther @sternenseemann