Skip to content

openroad: 2.0-unstable-2025-03-01 -> 26Q1#477789

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
gonsolo:openroad
Jan 23, 2026
Merged

openroad: 2.0-unstable-2025-03-01 -> 26Q1#477789
GaetanLepage merged 1 commit intoNixOS:masterfrom
gonsolo:openroad

Conversation

@gonsolo
Copy link
Contributor

@gonsolo gonsolo commented Jan 7, 2026

No description provided.

@gonsolo gonsolo marked this pull request as draft January 7, 2026 16:10
@gonsolo gonsolo mentioned this pull request Jan 7, 2026
Merged
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 7, 2026
@gonsolo gonsolo changed the title Openroad draft openroad: 2.0-unstable-2025-03-01 -> 2.0-unstable-2026-01-07 Jan 8, 2026
@gonsolo gonsolo mentioned this pull request Jan 8, 2026
Merged
2 tasks
@gonsolo gonsolo marked this pull request as ready for review January 8, 2026 21:09
@nixpkgs-ci nixpkgs-ci bot requested review from hzeller and trepetti January 8, 2026 21:13
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 14, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477789
Commit: 525c4d92dc12fcc0de289927a4a05c4fd0055e7a

x86_64-linux

✅ 1 package built:
  • openroad

@nixos-discourse
Copy link

nixos-discourse commented Jan 14, 2026

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6274

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 14, 2026

Please do not delete the template, it is there for a reason.

@SuperSandroBot
Copy link

SuperSandroBot commented Jan 14, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 477789
Commit: 525c4d92dc12fcc0de289927a4a05c4fd0055e7a (subsequent changes)
Merge: f8bb80dd2df96f18f2212b16b2d92b523c9308db

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/20985655004

x86_64-linux

✅ 1 package built:
  • openroad

aarch64-linux

❌ 1 package failed to build:
  • openroad
Error logs: `aarch64-linux`
openroad 
IntegrationTest tcl rcx passfail               =   0.23 sec*proc (1 test)
IntegrationTest tcl rmp log_compare            = 129.83 sec*proc (19 tests)
IntegrationTest tcl rsz log_compare            = 367.48 sec*proc (185 tests)
IntegrationTest tcl rsz passfail               =   0.43 sec*proc (1 test)
IntegrationTest tcl stt log_compare            =   3.13 sec*proc (7 tests)
IntegrationTest tcl tap log_compare            =   8.50 sec*proc (33 tests)
IntegrationTest tcl upf log_compare            =   3.04 sec*proc (4 tests)
IntegrationTest tcl utl log_compare            =   1.28 sec*proc (6 tests)
IntegrationTest tcl utl passfail               =   0.27 sec*proc (1 test)

Total Test time (real) = 566.94 sec


The following tests FAILED:

1129 - psm.gcd_all_vss.tcl (Failed)                      IntegrationTest tcl psm log_compare

1130 - psm.gcd_em_test_vdd.tcl (Failed)                  IntegrationTest tcl psm log_compare

1131 - psm.gcd_em_test_vdd.py (Failed)                   IntegrationTest python psm log_compare

1144 - psm.insert_decap1.tcl (Failed)                    IntegrationTest tcl psm log_compare

1146 - psm.insert_decap_with_padding1.tcl (Failed)       IntegrationTest tcl psm log_compare

Errors while running CTest

make: *** [Makefile:71: test] Error 8

x86_64-darwin

✅ No rebuilds

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • openroad

@gonsolo gonsolo force-pushed the openroad branch 5 times, most recently from 057e58a to e60a9cb Compare January 20, 2026 21:01
@nixpkgs-ci nixpkgs-ci bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jan 20, 2026
@gonsolo gonsolo changed the title openroad: 2.0-unstable-2025-03-01 -> 2.0-unstable-2026-01-07 openroad: 2.0-unstable-2025-03-01 -> 26Q1 Jan 20, 2026
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 21, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 477789
Commit: 708f296325017f226396b20a675d8ce5028ea1b2 (subsequent changes)
Merge: 242e97c8593d5f8b9431567b8b64ae8a57ec3df2

Logs: https://github.com/gonsolo/nixpkgs-review-gha/actions/runs/21203196197

x86_64-linux

✅ 3 packages built:
  • librelane
  • librelane.dist
  • openroad

aarch64-linux

✅ 3 packages built:
  • librelane
  • librelane.dist
  • openroad

x86_64-darwin

✅ No rebuilds

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • openroad

GaetanLepage
GaetanLepage reviewed Jan 21, 2026
View reviewed changes
GaetanLepage
GaetanLepage reviewed Jan 21, 2026
View reviewed changes
GaetanLepage
GaetanLepage reviewed Jan 21, 2026
View reviewed changes
@gonsolo gonsolo force-pushed the openroad branch 2 times, most recently from 0b11d1c to 4610280 Compare January 21, 2026 14:57
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jan 21, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477789
Commit: 4610280d36c943e79262e038b2dc388fee1a4ff4

x86_64-linux

✅ 3 packages built:
  • librelane
  • librelane.dist
  • openroad

aarch64-linux

✅ 3 packages built:
  • librelane
  • librelane.dist
  • openroad

aarch64-darwin

❌ 1 package failed to build:
  • openroad
Error logs: `aarch64-darwin`
openroad 
1 warning generated.
1 warning generated.
In file included from /nix/var/nix/builds/nix-88795-4214266846/source/src/pdn/src/via_repair.cpp:4:
In file included from /nix/var/nix/builds/nix-88795-4214266846/source/src/pdn/src/via_repair.h:11:
In file included from /nix/var/nix/builds/nix-88795-4214266846/source/src/odb/include/odb/db.h:29:
In file included from /nix/var/nix/builds/nix-88795-4214266846/source/src/odb/include/odb/dbTypes.h:11:
In file included from /nix/var/nix/builds/nix-88795-4214266846/source/src/odb/include/odb/geom.h:17:
In file included from /nix/var/nix/builds/nix-88795-4214266846/source/src/odb/include/odb/isotropy.h:20:
/nix/var/nix/builds/nix-88795-4214266846/source/src/utl/include/utl/Logger.h:171:5: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
  171 |     sprintf(tool_id, "%s-%04d", tool_names_[tool], id);
      |     ^
/nix/store/1b9inc48934yzc0m2w8j9sbva9svqhfy-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:180:1: note: 'sprintf' has been explicitly marked deprecated here
  180 | __deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
      | ^
/nix/store/1b9inc48934yzc0m2w8j9sbva9svqhfy-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: note: expanded from macro '__deprecated_msg'
  218 |         #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
      |                                                       ^
1 warning generated.
[ 89%] Built target pdn
make: *** [Makefile:146: all] Error 2

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jan 21, 2026

The build fails on darwin with:

CMake Error at /nix/store/syg57akx2cvcc8kamsravsxf1gypwvlv-cmake-4.1.2/share/cmake-4.1/Modules/GoogleTestAddTests.cmake:132 (message):
  Error running test executable.

    Path: '/nix/var/nix/builds/nix-88795-4214266846/source/build/src/mpl/test/cpp/TestSnapper'
    Working directory: '/nix/var/nix/builds/nix-88795-4214266846/source/src/mpl/test/cpp'
    Result: Process terminated due to timeout
    Output:
      Running main() from /nix/var/nix/builds/nix-36021-734476712/source/googletest/src/gtest_main.cc
      TestSnapper.
        ManufacturingGrid
        SingleLayer
        DoubleLayer
        MultiPitchPattern
        MultiOriginPattern
        SingleLayerWithUnalignablePin
        SingleLayerWithUnalignablePinThrowsException


Call Stack (most recent call first):
  /nix/store/syg57akx2cvcc8kamsravsxf1gypwvlv-cmake-4.1.2/share/cmake-4.1/Modules/GoogleTestAddTests.cmake:275 (gtest_discover_tests_impl)


make[2]: *** [src/mpl/test/cpp/CMakeFiles/TestSnapper.dir/build.make:338: src/mpl/test/cpp/TestSnapper] Error 1
make[2]: *** Suppression du fichier « src/mpl/test/cpp/TestSnapper »
make[1]: *** [CMakeFiles/Makefile2:11001: src/mpl/test/cpp/CMakeFiles/TestSnapper.dir/all] Error 2

@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 21, 2026 •
edited
Loading

The build fails on darwin with:

Not running checks on Darwin is not enough, building the tests has to be disabled too:

   cmakeFlags = [
-    (lib.cmakeBool "ENABLE_TESTS" true)
+    # Disable tests on Darwin to avoid discovery timeouts during build
+    (lib.cmakeBool "ENABLE_TESTS" (!stdenv.hostPlatform.isDarwin))
     (lib.cmakeBool "USE_SYSTEM_BOOST" true)

I just pushed this out.

And please note that the relaxed sandbox above worked.

@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 21, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 477789
Commit: d8d209124bebba245621638c05b3dce43ad03b47 (subsequent changes)
Merge: 57f3b1fc9ec8af945dad12a15eb6d636913b1a5b

Logs: https://github.com/gonsolo/nixpkgs-review-gha/actions/runs/21220062718

x86_64-linux

✅ 3 packages built:
  • librelane
  • librelane.dist
  • openroad

aarch64-linux

✅ 3 packages built:
  • librelane
  • librelane.dist
  • openroad

x86_64-darwin

✅ No rebuilds

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • openroad

@gonsolo gonsolo self-assigned this Jan 21, 2026
GaetanLepage
GaetanLepage reviewed Jan 21, 2026
View reviewed changes
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jan 22, 2026
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 22, 2026

@ofborg eval

GaetanLepage
GaetanLepage reviewed Jan 22, 2026
View reviewed changes
@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Jan 22, 2026
@GaetanLepage GaetanLepage requested a review from NickCao January 22, 2026 23:54
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jan 23, 2026
NickCao
NickCao reviewed Jan 23, 2026
View reviewed changes
@gonsolo @GaetanLepage @NickCao
openroad: 2.0-unstable-2025-03-01 -> 26Q1
a83ae39 
Co-authored-by: Gaétan Lepage <[email protected]>
Co-authored-by: Nick Cao <[email protected]>
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Jan 23, 2026
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 23, 2026

After your approval, @NickCao, and the merge-bot being eligible to merge, I'm going merge. I hope that's ok, @GaetanLepage.

@GaetanLepage GaetanLepage added this pull request to the merge queue Jan 23, 2026
Merged via the queue into NixOS:master with commit 1e748c0 Jan 23, 2026
26 checks passed
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 23, 2026

Thanks, @GaetanLepage 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao left review comments

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@hzeller hzeller Awaiting requested review from hzeller

@trepetti trepetti Awaiting requested review from trepetti

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

@gonsolo gonsolo

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gonsolo @nixos-discourse @SuperSandro2000 @SuperSandroBot @GaetanLepage @NickCao