buildPython*: extend overrideStdenvCompat to fixed-point arguments by ShamrockLee · Pull Request #477208 · NixOS/nixpkgs

ShamrockLee · 2026-01-05T16:45:35Z

Description

Implementation

Expose the stdenv argument as passthru.__stdenvPythonCompat when specified.
Attach the warning message to passthru.__stdenvPythonCompat (instead of inside overrideStdenvCompat).
Inside overrideStdenvCompat in python-packages-base.nix, construct a Python package with overridden stdenv if <python pkg>.__stdenvPythonCompat exists.
Add argument handleMsgStdenvArg to <python pkg>.override to pass the message handling function (ignoreing, warning, throwing, etc.), with a comment about its being an implementation detail.
Make tests.overriding's overridePythonAttrs-stdenv-deprecated ignore the deprecation warning with handleMsgStdenvArg.

Effect

Extend backward compatibility to python3Packages.buildPythonPackage's deprecated stdenv argument to the situation when buildPythonPackage takes fixed-point arguments, applying @MattSturgeon's suggestion in PR comment buildPython*: support fixed-point arguments #271387 (comment)
Make overrideSdenvCompat work with fixed-point arguments, giving us the freedom to decide whether to allow overridePythonAttrs to take extension-style update arguments (finalAttrs: previousPythonAttrs: { ... }) (issue Python: overridePythonAttrs should support final: prev: style overrides #258246 )
Guard the compatibility layer overrideStdenvCompat with tests even after warnings take effect, addressing @leona-ya and @MattSturgeon's PR comments treewide: use overlays to pass a custom stdenv to buildPythonPackage / bulidPythonApplication #476401 (comment) and treewide: use overlays to pass a custom stdenv to buildPythonPackage / bulidPythonApplication #476401 (comment)

Things done

Add a 👍 reaction to pull requests you find important.

MattSturgeon

I commented commit-by-commit, and the GitHub review summary seems very confused. Hopefully this posts everything ok... 🤞🏻

pkgs/development/interpreters/python/python-packages-base.nix

pkgs/development/interpreters/python/mk-python-derivation.nix

pkgs/development/interpreters/python/python-packages-base.nix

pkgs/development/interpreters/python/mk-python-derivation.nix

pkgs/test/overriding.nix

MattSturgeon

I tested this locally against #477760, and tests.eval built successfully. Admittedly, the test coverage for stdenv overrides isn't extensive, but it does provide a sanity check 😁

pkgs/development/interpreters/python/python-packages-base.nix

pkgs/development/interpreters/python/mk-python-derivation.nix

pkgs/development/interpreters/python/python-packages-base.nix

Co-authored-by: Matt Sturgeon <[email protected]>

… override value If Nix supports lazy attribute names in the future, this change will make `<python package>.override` warning-free and make such warning (or future throw) remediateable via another override.

with `passthru.__stdenvPythonCompat` Co-authored-by: Matt Sturgeon <[email protected]>

MattSturgeon

LGTM. Thanks! I think I'll merge this to avoid further delays.

MattSturgeon · 2026-01-20T11:22:24Z

pkgs/development/interpreters/python/python-packages-base.nix

The error message mentions buildPythonPackage and buildPythonApplication, but it also catches passing stdenv to overridePythonAttrs.

Ideally, we'd make this a smart warning that knows which function the user was using to incorrectly supply stdenv. I can't think of a sane way to handle that though.

I'm not suggesting we reword the warning to mention all three funtions, as that would quickly get rather verbose. I think this is out-of-scope for this PR anyway, as I think overrideStdenvCompat already handled overridePythonAttrs?

How about adding position information?

MattSturgeon · 2026-01-20T11:25:39Z

pkgs/development/interpreters/python/mk-python-derivation.nix

Would this benefit from a comment explaining why we add __stdenvPythonCompat (i.e. for overrideStdenvCompat), mentioning that it is internal, reminding us to remove when dropping overrideStdenvCompat, etc?

nixpkgs-ci · 2026-01-20T11:34:09Z

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-477208-to-release-25.11 origin/release-25.11
cd .worktree/backport-477208-to-release-25.11
git switch --create backport-477208-to-release-25.11
git cherry-pick -x 4ef0c2ded41c446cd8cd2611554487363e28ee15 5b114f0534d820d60186d402e8964b64d67e810e de48b6a845e7f206d8c11075a507814b6b5d13c7

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch from 45313a0 to 2543891 Compare January 5, 2026 16:50

nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 5, 2026

ShamrockLee mentioned this pull request Jan 5, 2026

Python: overridePythonAttrs should support final: prev: style overrides #258246

Open

ShamrockLee marked this pull request as ready for review January 5, 2026 17:11

ShamrockLee requested review from MattSturgeon, doronbehar and leona-ya January 5, 2026 17:12

ShamrockLee added the backport release-25.11 Backport PR automatically label Jan 5, 2026

nixpkgs-ci bot requested review from mweinelt and natsukium January 5, 2026 17:17

ShamrockLee mentioned this pull request Jan 5, 2026

Tracking: Python packages' overrideAttrs overriding and finalAttrs referencing #379602

Open

MattSturgeon reviewed Jan 5, 2026

View reviewed changes

MattSturgeon mentioned this pull request Jan 5, 2026

treewide: use overlays to pass a custom stdenv to buildPythonPackage / bulidPythonApplication #476401

Merged

13 tasks

nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 5, 2026

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch from 2543891 to c2d8b10 Compare January 5, 2026 20:33

ShamrockLee requested a review from MattSturgeon January 5, 2026 20:38

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch from c2d8b10 to a4a7c43 Compare January 5, 2026 20:44

MattSturgeon mentioned this pull request Jan 7, 2026

tests.eval: init #477760

Open

1 task

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch from a4a7c43 to 31c9079 Compare January 9, 2026 03:40

nixpkgs-ci bot removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 9, 2026

MattSturgeon reviewed Jan 9, 2026

View reviewed changes

pkgs/development/interpreters/python/python-packages-base.nix Outdated Show resolved Hide resolved

MattSturgeon reviewed Jan 9, 2026

View reviewed changes

pkgs/development/interpreters/python/mk-python-derivation.nix Outdated Show resolved Hide resolved

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch 2 times, most recently from ea064b0 to 22453e0 Compare January 12, 2026 05:52

ShamrockLee mentioned this pull request Jan 12, 2026

overridePythonAttrs: support extension-style newArgs (finalAttrs: args: { }) #479258

Draft

13 tasks

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch 2 times, most recently from d635ffa to 9cc99be Compare January 15, 2026 06:15

MattSturgeon reviewed Jan 15, 2026

View reviewed changes

pkgs/development/interpreters/python/python-packages-base.nix Outdated Show resolved Hide resolved

MattSturgeon reviewed Jan 15, 2026

View reviewed changes

pkgs/development/interpreters/python/python-packages-base.nix Outdated Show resolved Hide resolved

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch from 26bc9f8 to 7304784 Compare January 19, 2026 06:27

ShamrockLee and others added 3 commits January 19, 2026 14:29

buildPython*: overrideStdenvCompat: abstract warning

4ef0c2d

Co-authored-by: Matt Sturgeon <[email protected]>

buildPython*: overrideStdenvCompat: lower warnings down to the stdenv…

5b114f0

… override value If Nix supports lazy attribute names in the future, this change will make `<python package>.override` warning-free and make such warning (or future throw) remediateable via another override.

buildPython*: extend overrideStdenvCompat to fixed-point arguments

de48b6a

with `passthru.__stdenvPythonCompat` Co-authored-by: Matt Sturgeon <[email protected]>

ShamrockLee force-pushed the build-python-stdenv-compat-extended branch from 7304784 to de48b6a Compare January 19, 2026 06:29

ShamrockLee requested a review from MattSturgeon January 19, 2026 06:30

MattSturgeon approved these changes Jan 20, 2026

View reviewed changes

MattSturgeon changed the title ~~buildPython*: extend overrideStdenvCompat to fixed-point arguments and preserve its test after warning takes effect~~ buildPython*: extend overrideStdenvCompat to fixed-point arguments Jan 20, 2026

MattSturgeon added this pull request to the merge queue Jan 20, 2026

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 20, 2026

Merged via the queue into NixOS:master with commit e6959ad Jan 20, 2026
33 of 35 checks passed

ShamrockLee mentioned this pull request Jan 20, 2026

buildPythonPackage: overrideStdenvCompat: show position in its warning message #481980

Open

13 tasks

Uh oh!

Conversation

ShamrockLee commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Implementation

Effect

Things done

Uh oh!

MattSturgeon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MattSturgeon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MattSturgeon left a comment

Choose a reason for hiding this comment

Uh oh!

MattSturgeon Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

ShamrockLee Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

MattSturgeon Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nixpkgs-ci bot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShamrockLee commented Jan 5, 2026 •

edited

Loading