treewide: use overlays to pass a custom stdenv to buildPythonPackage / bulidPythonApplication by leona-ya · Pull Request #476401 · NixOS/nixpkgs

leona-ya · 2026-01-02T22:44:51Z

Bumping oldestSupportedRelease to 2511 failed because of multiple

evaluation warning: Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated. You should use their `.override` function instead, e.g:
    buildPythonPackage.override { stdenv = customStdenv; } { }

This PR either uses this approach or just removes superfluous stdenv declarations.

Required for #476384

Things done

Add a 👍 reaction to pull requests you find important.

leona-ya · 2026-01-02T23:25:04Z

If anyone has a better idea than to drop the overriding tests, I'm happy for that.

leona-ya · 2026-01-02T23:31:03Z

I evaled nixpkgs locally with

diff --git a/pkgs/development/interpreters/python/python-packages-base.nix b/pkgs/development/interpreters/python/python-packages-base.nix
index c513561ce6..94b7bc126b 100644
--- a/pkgs/development/interpreters/python/python-packages-base.nix
+++ b/pkgs/development/interpreters/python/python-packages-base.nix
@@ -51,7 +51,7 @@
         args:
         if !(lib.isFunction args) && (args ? stdenv) then
           lib.warnIf (lib.oldestSupportedReleaseIsAtLeast 2511) ''
-            Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated. You should use their `.override` function instead, e.g:
+            ${args.pname}: Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated. You should use their `.override` function instead, e.g:
               buildPythonPackage.override { stdenv = customStdenv; } { }
           '' (f'.override { inherit (args) stdenv; } (removeAttrs args [ "stdenv" ]))
         else

you may want to do something similar. Otherwise it's almost impossible to find the failures.

ShamrockLee · 2026-01-03T08:26:18Z

I had thought it would only be triggered after Nixpkgs 26.05 branch-off. Sorry for causing the trouble.

ShamrockLee · 2026-01-03T08:28:49Z

If anyone has a better idea than to drop the overriding tests, I'm happy for that.

The test is meant to be removed aftre tree-wide migration.

pkgs/applications/networking/browsers/webmacs/default.nix

pkgs/development/python-modules/psutil/default.nix

ShamrockLee · 2026-01-04T01:42:55Z

Let's merge after updating the webmacs commit message.

Thank you for fixing them!

Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

MattSturgeon

I had thought it would only be triggered after Nixpkgs 26.05 branch-off.

The "oldest supported release" gets bumped when the previous oldest supported release goes from "deprecated" to "unmaintained". It's not directly linked to branch-off; it usually happens a month or two after branch-off, IIUC.

I.e., 25.11 becomes the "oldest supported" at some point during the 26.05 cycle.

Sorry for causing the trouble.

We would've had to deal with this eventually, so no need to be sorry.

Thanks @leona-ya for handling it!

I evaled nixpkgs locally with [...] you may want to do something similar. Otherwise it's almost impossible to find the failures.

Good idea. It'd need to allow for pname being missing, but I agree it makes the error much more useful.

pkgs/development/python-modules/torchvision/default.nix

MattSturgeon · 2026-01-04T19:12:56Z

pkgs/test/overriding.nix

-      overridePythonAttrs-stdenv-deprecated = {
-        expr =
-          (package-stub.overridePythonAttrs (_: {
-            stdenv = pkgs.clangStdenv;
-          })).stdenv;
-        expected = pkgs.clangStdenv;
-      };
-      overridePythonAttrs-override-clangStdenv-deprecated-nested = {
-        expr =
-          (package-stub-gcc.overridePythonAttrs {
-            stdenv = pkgs.clangStdenv;
-          }).stdenv;
-        expected = pkgs.clangStdenv;
-      };


Ideally, I'd like to have a test that asserts the override still works and asserts the warning is printed. I don't think that's possible with the current overriding.nix.

I think we'd need to come up with something that evaluates test cases within a test derivation (similar to CI's eval or lib's lib/tests/test-with-nix.nix and ), that way we can capture the eval's stderr and make assertions on its content.

This is too complex to be in scope for this PR, and maybe too complex to be worth it for these two test cases. But maybe it'd be useful to have a way to implement more complex pkgs tests, like we already have for lib tests?

I also don't really know a way how this would be done easily. Also yes, probably out of scope here.

Agreed. If #477208 or another PR has a solution, it can revert this commit or introduce a new equivalent test. I don't want to block this PR by waiting for a solution.

Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…th an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…PythonApplication Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`. Passing the normal `stdenv` to `buildPythonApplication` doensn't do anything.

…ythonApplication Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`. Passing the normal `stdenv` to `buildPythonApplication` doensn't do anything.

… buildPythonApplication Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`. Passing `python.stdenv` to `buildPythonApplication` doensn't do anything

…ion with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…tion with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…on with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…th an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…plication with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…on with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

…n with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

These tests now throw a warning which is prohibited inside Nixpkgs: Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated. You should use their `.override` function instead, e.g: buildPythonPackage.override { stdenv = customStdenv; } { }

MattSturgeon

The only "changed" package is the test and the diff LGTM. Let's merge to unblock #476384

Thanks!

nixpkgs-ci · 2026-01-05T20:40:25Z

Successfully created backport PR for release-25.11:

[Backport release-25.11] treewide: use overlays to pass a custom stdenv to buildPythonPackage / bulidPythonApplication #477273

leona-ya marked this pull request as draft January 2, 2026 22:45

leona-ya force-pushed the push-ttpknlqpqyqq branch 2 times, most recently from 59d97f6 to 6f3fa6b Compare January 2, 2026 23:21

leona-ya marked this pull request as ready for review January 2, 2026 23:25

nixpkgs-ci bot requested review from jacg, lucasew, mvnetbiz, numinit and offlinehacker January 2, 2026 23:26

leona-ya requested review from MattSturgeon and ShamrockLee January 2, 2026 23:29

leona-ya mentioned this pull request Jan 2, 2026

lib/trivial: bump oldestSupportedRelease to 2511 #476384

Merged

13 tasks

ShamrockLee reviewed Jan 3, 2026

View reviewed changes

pkgs/applications/networking/browsers/webmacs/default.nix Outdated Show resolved Hide resolved

leona-ya force-pushed the push-ttpknlqpqyqq branch from 6f3fa6b to a7ac8bc Compare January 3, 2026 09:16

nixpkgs-ci bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Jan 3, 2026

ShamrockLee reviewed Jan 3, 2026

View reviewed changes

pkgs/development/python-modules/psutil/default.nix Show resolved Hide resolved

webmacs: pass custom stdenv to buildPythonApplication with an override

4abb280

Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

leona-ya force-pushed the push-ttpknlqpqyqq branch from a7ac8bc to 78cb6cb Compare January 4, 2026 15:35

MattSturgeon approved these changes Jan 4, 2026

View reviewed changes

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 4, 2026

MattSturgeon mentioned this pull request Jan 4, 2026

buildPython*: include package name in stdenv warning #476931

Merged

1 task

ShamrockLee mentioned this pull request Jan 5, 2026

buildPython*: migrate from buildPython* { inherit stdenv; ...; } to (buildPython*.override { inherit stdenv; }) { ... } #271947

Closed

13 tasks

leona-ya added 6 commits January 5, 2026 15:36

xpra: pass custom stdenv to buildPythonApplication with an override

8d063fd

Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.cupy: pass custom stdenv to buildPythonApplication wi…

1127e9d

…th an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.torchaudio: pass custom stdenv to buildPythonApplicat…

6a673c9

…ion with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

leona-ya force-pushed the push-ttpknlqpqyqq branch 2 times, most recently from f23c65d to f53ddbe Compare January 5, 2026 14:44

leona-ya added 8 commits January 5, 2026 15:44

python3Packages.torchvision: pass custom stdenv to buildPythonApplica…

8c40583

…tion with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.verilogae: pass custom stdenv to buildPythonApplicati…

c34997d

…on with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.vllm: pass custom stdenv to buildPythonApplication wi…

f8158a6

…th an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.dlib: pass custom stdenv to buildPythonApplication wi…

70efa53

…th an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.llama-cpp-python: pass custom stdenv to buildPythonAp…

5e028cc

…plication with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.warp-lang: pass custom stdenv to buildPythonApplicati…

5f4c3b6

…on with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

python3Packages.xformers: pass custom stdenv to buildPythonApplicatio…

ee013f1

…n with an override Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated with `oldestSupportedRelease = 2511`.

leona-ya force-pushed the push-ttpknlqpqyqq branch from f53ddbe to 9667e93 Compare January 5, 2026 14:44

This was referenced Jan 5, 2026

buildPython*: extend overrideStdenvCompat to fixed-point arguments #477208

Merged

Tracking: Python packages' overrideAttrs overriding and finalAttrs referencing #379602

Open

MattSturgeon approved these changes Jan 5, 2026

View reviewed changes

MattSturgeon added this pull request to the merge queue Jan 5, 2026

Merged via the queue into NixOS:master with commit f52e77d Jan 5, 2026
28 checks passed

ShamrockLee added the backport release-25.11 Backport PR automatically label Jan 5, 2026

github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 5, 2026

nixpkgs-ci bot mentioned this pull request Jan 5, 2026

[Backport release-25.11] treewide: use overlays to pass a custom stdenv to buildPythonPackage / bulidPythonApplication #477273

Open

leona-ya deleted the push-ttpknlqpqyqq branch January 6, 2026 11:54

Uh oh!

Conversation

leona-ya commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

leona-ya commented Jan 2, 2026

Uh oh!

leona-ya commented Jan 2, 2026

Uh oh!

ShamrockLee commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShamrockLee commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShamrockLee commented Jan 4, 2026

Uh oh!

MattSturgeon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MattSturgeon Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leona-ya Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

MattSturgeon Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

MattSturgeon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nixpkgs-ci bot commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leona-ya commented Jan 2, 2026 •

edited

Loading

ShamrockLee commented Jan 3, 2026 •

edited

Loading

ShamrockLee commented Jan 3, 2026 •

edited

Loading

MattSturgeon left a comment •

edited

Loading

MattSturgeon Jan 4, 2026 •

edited

Loading