pkgsLLVM.git-doc: improve eval error#474199
Merged
doronbehar merged 1 commit intoNixOS:masterfrom Dec 27, 2025
Merged
Conversation
11 tasks
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
uninsane
approved these changes
Dec 26, 2025
nixpkgs-ci
bot
added
12.approvals: 1
trofi
force-pushed
the
pkgsLLVM.git-doc-fix-eval
branch
from
285a6b6 to
f7ae2ec
Compare
doronbehar
reviewed
Dec 26, 2025
Contributor
doronbehar
left a comment
doronbehar
left a comment
There was a problem hiding this comment.
I don't understand the relation of this PR to #432788 or why is gitFull.outputs dependent upon pkgs v.s pkgsLLVM but I guess this makes sense.
Before the change `pkgsLLVM.git-doc` evaluated to uncatchable error:
$ nix build --no-link -f. pkgsLLVM.git-doc
error:
… while evaluating a branch condition
at pkgs/top-level/splice.nix:59:11:
58| # on to splice them together.
59| if lib.isDerivation defaultValue then
| ^
60| augmentedValue
… while evaluating the attribute 'git-doc'
at pkgs/top-level/all-packages.nix:1159:3:
1158|
1159| git-doc = lib.addMetaAttrs {
| ^
1160| description = "Additional documentation for Git";
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: attribute 'doc' missing
at pkgs/top-level/all-packages.nix:1165:5:
1164| '';
1165| } gitFull.doc;
| ^
1166|
Did you mean src?
After the change it's more typical `throw` error:
$ nix build --no-link -f. pkgsLLVM.git-doc
error:
… while evaluating a branch condition
at pkgs/top-level/splice.nix:59:11:
58| # on to splice them together.
59| if lib.isDerivation defaultValue then
| ^
60| augmentedValue
… while evaluating the attribute 'git-doc'
at pkgs/top-level/all-packages.nix:1159:3:
1158|
1159| git-doc =
| ^
1160| # doc attribnute is not present at least for pkgsLLVM
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: 'git-doc' can't be evaluated as 'gitFull' does no expose 'doc' attribute
Co-authored-by: Colin <[email protected]>
Co-authored-by: Doron Behar <[email protected]>
trofi
force-pushed
the
pkgsLLVM.git-doc-fix-eval
branch
from
eb60b5e to
0ce6504
Compare
Contributor
Author
Before PR #432788
That it's a typical way to declare "no support". Note that After PR #432788
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change
pkgsLLVM.git-docevaluated to uncatchable error:After the change it's more typical
throwerror:Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.