Skip to content

yosys-synlig: drop#473242

Merged
NickCao merged 1 commit intoNixOS:masterfrom
gonsolo:yosys-synlig
Jan 6, 2026
Merged

yosys-synlig: drop#473242
NickCao merged 1 commit intoNixOS:masterfrom
gonsolo:yosys-synlig

Conversation

@gonsolo
Copy link
Contributor

@gonsolo gonsolo commented Dec 22, 2025

Synlig has stopped development, that last commit is from Dec 2024, it seems yosys-slang is used nowadays.

@gonsolo gonsolo mentioned this pull request Dec 22, 2025
Merged
@nixpkgs-ci nixpkgs-ci bot requested a review from hzeller December 22, 2025 10:44
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 22, 2025
@gonsolo gonsolo mentioned this pull request Dec 22, 2025
Merged
@hzeller
Copy link
Contributor

hzeller commented Dec 22, 2025

I see if I can offline figure out to make it compatible with latest yosys

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 22, 2025
GaetanLepage
GaetanLepage requested changes Dec 24, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this package actually broken or simply "unmaintained"?
If it still builds, marking is as broken is not the right action.

Also, is there an official statement from upstream stating that development has stopped? Or is your observation just based on the date of the latest commit?

If it is indeed "archived/unmaintained" AND if it does not make any sense to keep it around, then we should properly drop the package. This means removing the files and adding an entry in pkgs/top-level/aliases.nix.

@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 2, 2026

Is this package actually broken or simply "unmaintained"? If it still builds, marking is as broken is not the right action.

It's broken with newer yosys and is the only reason (after you merged my patch for silice) to not update yosys.

Also, is there an official statement from upstream stating that development has stopped? Or is your observation just based on the date of the latest commit?

The last commit is from Dec 2024, and I emailed the main commiter: No answer.

If it is indeed "archived/unmaintained" AND if it does not make any sense to keep it around, then we should properly drop the package. This means removing the files and adding an entry in pkgs/top-level/aliases.nix.

I would vote to drop it; if the maintainer steps up again it should be easily ressurected, right?

@GaetanLepage
Copy link
Contributor

GaetanLepage commented Jan 2, 2026

I would vote to drop it; if the maintainer steps up again it should be easily ressurected, right?

If @hzeller agrees, then sure, let's drop it.

@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: kernel The Linux kernel 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 6, 2026
@nixpkgs-ci nixpkgs-ci bot removed 6.topic: nim Nim programing language 6.topic: mate The MATE Desktop Environment 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. 6.topic: julia Julia is a high-level, high-performance dynamic language for technical computing. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: nvidia Nvidia-specific issues and fixes 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: teams Relating to team creation, updates, other management actions 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 6.topic: tree-sitter Tree-sitter is a parser generator tool and an incremental parsing library. labels Jan 6, 2026
@GaetanLepage GaetanLepage requested a review from NickCao January 6, 2026 18:47
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 6, 2026
@NickCao
Copy link
Member

NickCao commented Jan 6, 2026

Correct commit message would be: yosys-synlig: drop, not a big deal though.

@NickCao NickCao changed the title synlig: drop yosys-synlig: drop Jan 6, 2026
@NickCao NickCao added this pull request to the merge queue Jan 6, 2026
@hzeller
Copy link
Contributor

hzeller commented Jan 6, 2026

Drop sounds like a good choice for now.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jan 6, 2026
Merged via the queue into NixOS:master with commit a4c7fa2 Jan 6, 2026
36 of 38 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 6, 2026

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-473242-to-release-25.11 origin/release-25.11
cd .worktree/backport-473242-to-release-25.11
git switch --create backport-473242-to-release-25.11
git cherry-pick -x 0f1f388f3259d652dab39d6362da364a7c73199b

@gonsolo gonsolo removed the backport release-25.11 Backport PR automatically label Jan 6, 2026
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 6, 2026

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

This is a package removal; backporting to stable is not necessary as it would be a breaking change for 25.11 users.

@gonsolo gonsolo deleted the yosys-synlig branch January 6, 2026 23:42
@Emin017 Emin017 mentioned this pull request Jan 11, 2026
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

+1 more reviewer

@hzeller hzeller hzeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gonsolo @hzeller @GaetanLepage @NickCao