Skip to content

buildPythonPackage: chore: remove unnecessary set update for passthru value#471681

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
ShamrockLee:build-python-cleanup-set-update
Dec 17, 2025
Merged

buildPythonPackage: chore: remove unnecessary set update for passthru value#471681
mweinelt merged 1 commit intoNixOS:masterfrom
ShamrockLee:build-python-cleanup-set-update

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Dec 17, 2025

This PR is a minor clean-up for the syntax leftover from commit d6a757b ("buildPython*: prioritize user-specified passthru attrs") in PR #378566.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested review from mweinelt and natsukium December 17, 2025 14:30
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 17, 2025
@ShamrockLee ShamrockLee added the backport release-25.11 Backport PR automatically label Dec 17, 2025
@ShamrockLee ShamrockLee changed the title buildPythonPackage: chore: remove unnecessary set update buildPythonPackage: chore: remove unnecessary set update for passthru value Dec 17, 2025
@ShamrockLee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 471681
Commit: 353eec600b300fa8e6b67bf8ff14d7f38ab1cdf5 (subsequent changes)
Merge: 17e922a0422a01c7fc3e32431f4ed4857721f106

Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/20306340645


x86_64-linux

No rebuilds


aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@mweinelt mweinelt added this pull request to the merge queue Dec 17, 2025
Merged via the queue into NixOS:master with commit 532bd8d Dec 17, 2025
39 of 42 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 17, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-471681-to-release-25.05 origin/release-25.05
cd .worktree/backport-471681-to-release-25.05
git switch --create backport-471681-to-release-25.05
git cherry-pick -x 353eec600b300fa8e6b67bf8ff14d7f38ab1cdf5

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants