Skip to content

jetbrains.jcef: fix missing cef_server#470840

Merged
adamcstephens merged 3 commits intoNixOS:masterfrom
aoli-al:cef-server
Dec 22, 2025
Merged

jetbrains.jcef: fix missing cef_server#470840
adamcstephens merged 3 commits intoNixOS:masterfrom
aoli-al:cef-server

Conversation

@aoli-al
Copy link
Member

@aoli-al aoli-al commented Dec 14, 2025 •
edited
Loading

This PR fixes the missing cef_server output produce by the jcef build. This PR will fix AI Assistant plugin crash mentioned here: #469024 (comment)

It also simplifies the build script and rely on the create_modules.sh script to post process the build results.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@aoli-al aoli-al mentioned this pull request Dec 14, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Dec 14, 2025
@aoli-al aoli-al force-pushed the cef-server branch 2 times, most recently from bab1852 to 880b18e Compare December 14, 2025 21:17
@aoli-al
Copy link
Member Author

aoli-al commented Dec 15, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 470840
Commit: 880b18e23aa160c810cd91a4fd4ca94cceea77f8 (subsequent changes)
Merge: def1ee21de5cfb5de586f504076451ac06f10324

Logs: https://github.com/aoli-al/nixpkgs-review-gha/actions/runs/20216869905

x86_64-linux

❌ 1 package failed to build:
  • animeko
✅ 22 packages built:
  • jetbrains.aqua
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.dataspell
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea-community (jetbrains.idea-community-src)
  • jetbrains.idea-community-bin
  • jetbrains.idea-ultimate
  • jetbrains.jcef
  • jetbrains.jdk
  • jetbrains.jdk.debug
  • jetbrains.mps
  • jetbrains.phpstorm
  • jetbrains.pycharm-community (jetbrains.pycharm-community-src)
  • jetbrains.pycharm-community-bin
  • jetbrains.pycharm-professional
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm
  • jetbrains.writerside
Error logs: `x86_64-linux`
animeko 
    libgbm.so.1 -> found: /nix/store/pw8v6hlrg7lz2d3x115x3zy80bbhx1x9-mesa-libgbm-25.1.0/lib
setting RPATH to: /nix/store/p4fk8qb6cy0zs65j6h50rh9bs7hnsgif-libdrm-2.4.128/lib:/nix/store/pw8v6hlrg7lz2d3x115x3zy80bbhx1x9-mesa-libgbm-25.1.0/lib
searching for dependencies of /nix/store/h62s0v2ldvny3mxcxvlhc456bcj4ai08-animeko-5.2.0/lib/runtime/lib/libnewt_head.so
    libX11.so.6 -> found: /nix/store/ja09m2gfni7pqk4bsrhjb8y9cq74rspp-libx11-1.8.12/lib
    libXrandr.so.2 -> found: /nix/store/llr8wn0a3q8vfrg6i7vr2l2k66izm56a-libxrandr-1.5.4/lib
    libXcursor.so.1 -> found: /nix/store/ldl1g8r8jfhjv4asb7zkr7ljpgk7q6dv-libxcursor-1.2.3/lib
    libXi.so.6 -> found: /nix/store/xg9763xyrnkxhvqgvxdbfiwxnmz391rx-libxi-1.8.2/lib
setting RPATH to: /nix/store/ja09m2gfni7pqk4bsrhjb8y9cq74rspp-libx11-1.8.12/lib:/nix/store/llr8wn0a3q8vfrg6i7vr2l2k66izm56a-libxrandr-1.5.4/lib:/nix/store/ldl1g8r8jfhjv4asb7zkr7ljpgk7q6dv-libxcursor-1.2.3/lib:/nix/store/xg9763xyrnkxhvqgvxdbfiwxnmz391rx-libxi-1.8.2/lib
searching for dependencies of /nix/store/h62s0v2ldvny3mxcxvlhc456bcj4ai08-animeko-5.2.0/lib/runtime/lib/server/libjsig.so
searching for dependencies of /nix/store/h62s0v2ldvny3mxcxvlhc456bcj4ai08-animeko-5.2.0/lib/runtime/lib/server/libjvm.so
    libstdc++.so.6 -> found: /nix/store/xm08aqdd7pxcdhm0ak6aqb1v7hw5q6ri-gcc-14.3.0-lib/lib
    libgcc_s.so.1 -> found: /nix/store/shs2lyjm5yv7fmg4pwyvrlv9zr4macmv-gcc-14.3.0-libgcc/lib
setting RPATH to: /nix/store/xm08aqdd7pxcdhm0ak6aqb1v7hw5q6ri-gcc-14.3.0-lib/lib:/nix/store/shs2lyjm5yv7fmg4pwyvrlv9zr4macmv-gcc-14.3.0-libgcc/lib
auto-patchelf: 4 dependencies could not be satisfied
error: auto-patchelf could not satisfy dependency libboost_filesystem.so.1.87.0 wanted by /nix/store/h62s0v2ldvny3mxcxvlhc456bcj4ai08-animeko-5.2.0/lib/runtime/lib/cef_server
error: auto-patchelf could not satisfy dependency libthrift.so.0.20.0 wanted by /nix/store/h62s0v2ldvny3mxcxvlhc456bcj4ai08-animeko-5.2.0/lib/runtime/lib/cef_server
error: auto-patchelf could not satisfy dependency libboost_atomic.so.1.87.0 wanted by /nix/store/h62s0v2ldvny3mxcxvlhc456bcj4ai08-animeko-5.2.0/lib/runtime/lib/cef_server
error: auto-patchelf could not satisfy dependency libboost_system.so.1.87.0 wanted by /nix/store/h62s0v2ldvny3mxcxvlhc456bcj4ai08-animeko-5.2.0/lib/runtime/lib/cef_server
auto-patchelf failed to find all the required dependencies.
Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.

aarch64-linux

❌ 2 packages failed to build:
  • jetbrains.idea-community-src
  • jetbrains.pycharm-community (jetbrains.pycharm-community-src)
✅ 20 packages built:
  • jetbrains.aqua
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.dataspell
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea-community (jetbrains.idea-community-bin)
  • jetbrains.idea-ultimate
  • jetbrains.jcef
  • jetbrains.jdk
  • jetbrains.jdk.debug
  • jetbrains.mps
  • jetbrains.phpstorm
  • jetbrains.pycharm-community-bin
  • jetbrains.pycharm-professional
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm
  • jetbrains.writerside

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@aoli-al aoli-al requested review from liff and pokon548 December 15, 2025 15:48
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 15, 2025
@aoli-al
Copy link
Member Author

aoli-al commented Dec 15, 2025

@pokon548 Could you please check the animeko changes?

jetbrains.jdk now ships cef_server and this breaks animeko because current build trieds to run patchelf on cef_server again but animeko did not declare all buildInputs.

The simplest fix is to just add missing dependencies. However, I'm wondering if we can filter cef_server out since it is already patched.

@aoli-al
Copy link
Member Author

aoli-al commented Dec 15, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 470840
Commit: 3450453551b3b6333b9dfba8b3fa28444486f276 (subsequent changes)
Merge: 8f0ad86f9da1c7602ffb30f5243e3f0d85bbb118

Logs: https://github.com/aoli-al/nixpkgs-review-gha/actions/runs/20238379755

x86_64-linux

✅ 19 packages built:
  • animeko
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.dataspell
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea
  • jetbrains.idea-oss
  • jetbrains.jcef
  • jetbrains.jdk
  • jetbrains.jdk.debug
  • jetbrains.mps
  • jetbrains.phpstorm
  • jetbrains.pycharm
  • jetbrains.pycharm-oss
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm

aarch64-linux

❌ 2 packages failed to build:
  • jetbrains.idea-oss
  • jetbrains.pycharm-oss
✅ 16 packages built:
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.dataspell
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea
  • jetbrains.jcef
  • jetbrains.jdk
  • jetbrains.jdk.debug
  • jetbrains.mps
  • jetbrains.phpstorm
  • jetbrains.pycharm
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@pokon548
Copy link
Contributor

pokon548 commented Dec 17, 2025

@pokon548* Could you please check the animeko changes?

Thanks for your PR! Tested on my laptop, works fine for me.

The simplest fix is to just add missing dependencies. However, I'm wondering if we can filter cef_server out since it is already patched.

Packaging animeko requires to dynamically build arbitrary binaries from upstream. Currently, I am using autoPatchelfHook to workaround that issue, but autoPatchelfHook does not provide a sort of filter mechanism to just filter out one output. For now, adding missing dependences may be a better choice for me.

@aoli-al aoli-al mentioned this pull request Dec 21, 2025
Open
13 tasks
@Eveeifyeve
Copy link
Member

Eveeifyeve commented Dec 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 470840
Commit: 6475dd20d874dda1c676cda8624e9e9947116c14 (subsequent changes)
Merge: c61eab42cc2600bb9deb35d631aea7656bebf2b5

Logs: https://github.com/Eveeifyeve/nixpkgs-review-gha/actions/runs/20413502801

x86_64-linux

✅ 19 packages built:
  • animeko
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.dataspell
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea
  • jetbrains.idea-oss
  • jetbrains.jcef
  • jetbrains.jdk
  • jetbrains.jdk.debug
  • jetbrains.mps
  • jetbrains.phpstorm
  • jetbrains.pycharm
  • jetbrains.pycharm-oss
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm

aarch64-linux

❌ 2 packages failed to build:
  • jetbrains.idea-oss
  • jetbrains.pycharm-oss
✅ 16 packages built:
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.dataspell
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea
  • jetbrains.jcef
  • jetbrains.jdk
  • jetbrains.jdk.debug
  • jetbrains.mps
  • jetbrains.phpstorm
  • jetbrains.pycharm
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@Eveeifyeve
Copy link
Member

Eveeifyeve commented Dec 22, 2025

I might run nixpkgs-review locally to test these changes and find out the logs.

@aoli-al
Copy link
Member Author

aoli-al commented Dec 22, 2025

The jetbrains.*-oss has been failing for a while. It it probably not caused by this PR

@Eveeifyeve
Copy link
Member

Eveeifyeve commented Dec 22, 2025 •
edited
Loading

The jetbrains.*-oss has been failing for a while. It it probably not caused by this PR

Has it been fixed upstream or is there a fix in another pr? Because I am happy to approve if there is a fix awaiting/upstreamed and not caused by this pr.

@aoli-al
Copy link
Member Author

aoli-al commented Dec 22, 2025

I think there is still a PR pending: #470774

@aoli-al
Copy link
Member Author

aoli-al commented Dec 22, 2025

I found the error log from CI:

2025-12-15T16:01:53.6495019Z error: Cannot build '/nix/store/d8za6y2szhz92sgdnvjrkgrgcxgfp9lq-jetbrains-jdk-17.0.15-b1381.drv'.
2025-12-15T16:01:53.6495931Z        Reason: builder failed with exit code 2.
2025-12-15T16:01:53.6500280Z        Output paths:
2025-12-15T16:01:53.6500646Z          /nix/store/7jjcc1s5x4lifj64bnr4hka821zm0jfa-jetbrains-jdk-17.0.15-b1381-debug
2025-12-15T16:01:53.6504159Z          /nix/store/lsxk8667n97vwyn644r7k96ixi63lnqp-jetbrains-jdk-17.0.15-b1381
2025-12-15T16:01:53.6504503Z        Last 25 log lines:
2025-12-15T16:01:53.6505162Z        > /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:700:54: error: storing the address of local variable 'do_not_use' in '*this.Assembler::current' [-Werror=dangling-pointer=]
2025-12-15T16:01:53.6505870Z        >   700 |   void set_current(Instruction_aarch64* i) { current = i; }
2025-12-15T16:01:53.6506161Z        >       |                                              ~~~~~~~~^~~
2025-12-15T16:01:53.6506732Z        > /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp: In function 'void Assembler::sbfm(Register, Register, unsigned int, unsigned int)':
2025-12-15T16:01:53.6507597Z        > /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:316:36: note: 'do_not_use' declared here
2025-12-15T16:01:53.6508140Z        >   316 | #define starti Instruction_aarch64 do_not_use(this); set_current(&do_not_use)
2025-12-15T16:01:53.6508478Z        >       |                                    ^~~~~~~~~~
2025-12-15T16:01:53.6509386Z        > /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:857:5: note: in expansion of macro 'starti'
2025-12-15T16:01:53.6510003Z        > /nix/store/5728bdap49nsnk1c8zq96fqsm4b7ihj6-gnugrep-3.12/bin/grep: write error: Broken pipe
2025-12-15T16:01:53.6510405Z        >    ... (rest of output omitted)
2025-12-15T16:01:53.6510605Z        >
2025-12-15T16:01:53.6510953Z        > * All command lines available in /build/source/build/linux-aarch64-server-release/make-support/failure-logs.
2025-12-15T16:01:53.6511755Z        > === End of repeated output ===
2025-12-15T16:01:53.6511961Z        >
2025-12-15T16:01:53.6512118Z        > No indication of failed target found.
2025-12-15T16:01:53.6512373Z        > Hint: Try searching the build log for '] Error'.
2025-12-15T16:01:53.6512777Z        > Hint: See doc/building.html#troubleshooting for assistance.
2025-12-15T16:01:53.6513040Z        >
2025-12-15T16:01:53.6513225Z        > make[1]: *** [/build/source/make/Init.gmk:318: main] Error 2
2025-12-15T16:01:53.6513532Z        > make: *** [/build/source/make/Init.gmk:189: images] Error 2
2025-12-15T16:01:53.6513781Z        > + do_exit 2
2025-12-15T16:01:53.6513938Z        > + exit_code=2
2025-12-15T16:01:53.6514098Z        > + '[' 0 -eq 1 ']'
2025-12-15T16:01:53.6514269Z        > + '[' 0 -eq 1 ']'
2025-12-15T16:01:53.6514433Z        > + exit 2
2025-12-15T16:01:53.6514583Z        For full logs, run:
2025-12-15T16:01:53.6514922Z          nix log /nix/store/d8za6y2szhz92sgdnvjrkgrgcxgfp9lq-jetbrains-jdk-17.0.15-b1381.drv

jetbrains.jdk-17 is failing. This PR should fix it: #430439 😅

Eveeifyeve
Eveeifyeve approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as said, The fix for the jdk is awaiting in a pr already mentioned. LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 22, 2025
@adamcstephens adamcstephens added this pull request to the merge queue Dec 22, 2025
Merged via the queue into NixOS:master with commit 32c6d02 Dec 22, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pokon548 pokon548 Awaiting requested review from pokon548

@liff liff Awaiting requested review from liff

1 more reviewer

@Eveeifyeve Eveeifyeve Eveeifyeve approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aoli-al @pokon548 @Eveeifyeve @adamcstephens