jetbrains: idea-oss, pycharm-oss: 2025.1.1.1 -> 2025.3.1 by theCapypara · Pull Request #470774 · NixOS/nixpkgs

theCapypara · 2025-12-14T15:51:52Z

Updates idea-oss and pycharm-oss to the latest version. Fixes various build issues & also automates generating the jps & restarter hashes.

The source build is now also always updated from the latest release info, instead of just using whatever the bin versions use. This means the build processes are now independent.

There's quite a bit of code duplication between the bin/source update scripts. I plan to refactor this eventually. After this PR I'll introduce support for updateScript if & when #470147 is also merged.

IMO we should exceptionally backport this to 25.11 since we haven't touched the source versions in a long time & to get the fixes onto the stable branch. Also since we are going to backport #466331 as well.

Things done

Add a 👍 reaction to pull requests you find important.

MattSturgeon

Lot's of code here I'm not too familiar with, but looking at the diff things seem ok.

pkgs/applications/editors/jetbrains/source/build.nix

pkgs/applications/editors/jetbrains/source/update.py

theCapypara · 2025-12-17T22:41:34Z

It seems that some more links on the cache redirector are now dead? Maybe they are entirely switching away from it now. Will check.

MattSturgeon · 2025-12-17T23:49:14Z

Do those FODs use fallback urls or mirrors? Maybe #470643 not being fully effective is related 🤔

Either way, if the primary URLs are 404ing then they probably need fixing, I assume.

theCapypara · 2025-12-18T22:58:30Z

@MattSturgeon Can you try again? Might have been a temporary issue on Jetbrain's end. The URLs in your build logs (e. g. https://cache-redirector.jetbrains.com/packages.jetbrains.team/maven/p/grazi/grazie-platform-public/ai/grazie/utils/utils-ktor-jvm/0.8.74/utils-ktor-jvm-0.8.74.jar) are working and I can build everything just fine.

I think that service is just a mirror for maven repos and some other pages, we could probably just add the non-mirrored URLs as well, but that'd require some more changes here. Currently fallback URLs are not used. I'll write that down as another future improvement to do.

For example for the above URL https://packages.jetbrains.team/maven/p/grazi/grazie-platform-public/ai/grazie/utils/utils-ktor-jvm/0.8.74/utils-ktor-jvm-0.8.74.jar works just fine as well.

There were some URLs I noticed changed location and I replaced them with the new one used. But those would actually probably also work via the cache redirector... I don't know much about it's purpose - or anything really.

theCapypara · 2025-12-19T00:41:48Z

That's really odd. I have no idea why it doesn't build inside Github Actions.

theCapypara · 2025-12-21T14:30:08Z

I added fallback URLs that don't use the cache redirector service, hopefully it works now?

theCapypara · 2025-12-21T15:33:34Z

Turns out the download failures were a red herring (I still added the flag --no-retry-all-errors, since we do not need to retry on 404 errors; we are currently absuing fetchurls urls mechanism to "select" a mirror from a list of candidates for the maven packages...)

The actual error is this:

2025-12-18T23:25:03.2848370Z error: Cannot build '/nix/store/cnc3pr9nfdi5d894afjac1zh4852ifhy-jps-bootstrap-repository.drv'.
2025-12-18T23:25:03.2849420Z        Reason: builder failed with exit code 1.
2025-12-18T23:25:03.2849869Z        Output paths:
2025-12-18T23:25:03.2850412Z          /nix/store/19rigv7qs7c1m2a8w1440ps7sd9l7ay7-jps-bootstrap-repository
2025-12-18T23:25:03.2851025Z        Last 6 log lines:
2025-12-18T23:25:03.2851888Z        > Buildfile: /nix/store/nihhv0i5i3ca24igdj2wz2hg1jc72b7f-source/platform/jps-bootstrap/jps-bootstrap-classpath.xml
2025-12-18T23:25:03.2853094Z        >
2025-12-18T23:25:03.2853362Z        > BUILD FAILED
2025-12-18T23:25:03.2854554Z        > /nix/store/nihhv0i5i3ca24igdj2wz2hg1jc72b7f-source/platform/jps-bootstrap/jps-bootstrap-classpath.xml:18: Directory /build/tmp creation was not successful for an unknown reason
2025-12-18T23:25:03.2855831Z        >
2025-12-18T23:25:03.2856130Z        > Total time: 0 seconds
2025-12-18T23:25:03.2856503Z        For full logs, run:
2025-12-18T23:25:03.2857128Z          nix log /nix/store/cnc3pr9nfdi5d894afjac1zh4852ifhy-jps-bootstrap-repository.drv
2025-12-18T23:25:03.3605738Z building '/nix/store/by013kvvjhrmld6lhbm1nfbv5lypc4gs-clion-2025.2.5.drv'...
2025-12-18T23:25:03.3610983Z error: Cannot build '/nix/store/bxrnfmdl1vakh93d3hz5y6q8j7jxinvb-jps-bootstrap-253.28294.336.drv'.
2025-12-18T23:25:03.3611968Z        Reason: 1 dependency failed.
2025-12-18T23:25:03.3612442Z        Output paths:
2025-12-18T23:25:03.3614181Z          /nix/store/sa8fjf34rs31980hlzh478zrjs217irq-jps-bootstrap-253.28294.336
2025-12-18T23:25:03.3617121Z error: Build failed due to failed dependency

The ant build step is here: https://github.com/JetBrains/intellij-community/blob/master/platform/jps-bootstrap/jps-bootstrap-classpath.xml#L18

I'm unfortunately not sure what this could mean. Maybe some incompatiblity in the GitHub Hosted Runners?

MattSturgeon

A couple non-blocking bash hygine nits, in case you weren't aware of the subtleties here. Up to you whether to action them.

Overall PR still SGTM.

pkgs/applications/editors/jetbrains/source/build.nix

theCapypara · 2025-12-25T10:03:17Z

Note for myself: I did not add plugin updates here, I expect #470147 to be merged first, if we backport this we should also run the plugin update script for the backport.

I'm removing the label to do a manual backport later.

theCapypara · 2025-12-25T10:48:58Z

I was able to squash the review feedback into previous commits.

And:

I added one more commit that makes sure that the source/update.py writes the source/sources.json repositories entries without https:// or https://cache-redirector.jetbrains.com/ prefixes like I manually edited them; almost missed that.
I updated the IDEs to 2025.3.1 and remove the previous update commit (d8dc15032231 jetbrains: idea-oss, pycharm-oss: 2025.1.1.1 -> 2025.3) from this PR.

Eveeifyeve · 2025-12-25T11:11:23Z

Please credit the suggestions provided by the reviewers via Co-authored-by so we are not breaking licensing.

MattSturgeon · 2025-12-25T11:29:21Z

Please credit the suggestions provided by the reviewers via Co-authored-by so we are not breaking licensing.

While Co-authored-by metadata can be nice to have, I don't think it's a licensing requirement.

Git commit metadata isn't the authoritative source of copyright in nixpkgs; licensing is covered by COPYING, which attributes copyright collectively to:

Copyright (c) 2003-2025 Eelco Dolstra and the Nixpkgs/NixOS contributors

Regardless, I'm fine for my suggestions to be merged into Nixpkgs without attribution.

TL;DR: Adding Co-authored-by can be good practice, but it isn't required here for licensing reasons.

MattSturgeon · 2025-12-25T11:40:54Z

Note for myself: I did not add plugin updates here, I expect #470147 to be merged first, if we backport this we should also run the plugin update script for the backport.

I'm removing the label to do a manual backport later.

SGTM. I've ~~queued~~ merged #470147.

When backporting, you'll probably end up cherry picking this and doing a separate "update plugins" commit with a Not-cherry-picked-because tag. The same will apply to future updates, I imagine.

Not-cherry-picked-because: plugins are only maintained on 25.11

Or

Not-cherry-picked-because: plugins have been dropped in 26.05

theCapypara · 2025-12-25T12:01:19Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 470774
Commit: 3624c534f9bf0b37890764543fbf9d596e3bf98d (subsequent changes)
Merge: 039b9d95d6bae25e7f565e6ae0d99621f0953339

Logs: https://github.com/theCapypara/nixpkgs-review-gha/actions/runs/20503865501

`x86_64-linux`

✅ 15 packages built:

jetbrains.clion
jetbrains.datagrip
jetbrains.dataspell
jetbrains.gateway
jetbrains.goland
jetbrains.idea
jetbrains.idea-oss
jetbrains.mps
jetbrains.phpstorm
jetbrains.pycharm
jetbrains.pycharm-oss
jetbrains.rider
jetbrains.ruby-mine
jetbrains.rust-rover
jetbrains.webstorm

`aarch64-linux`

✅ 15 packages built:

jetbrains.clion
jetbrains.datagrip
jetbrains.dataspell
jetbrains.gateway
jetbrains.goland
jetbrains.idea
jetbrains.idea-oss
jetbrains.mps
jetbrains.phpstorm
jetbrains.pycharm
jetbrains.pycharm-oss
jetbrains.rider
jetbrains.ruby-mine
jetbrains.rust-rover
jetbrains.webstorm

`x86_64-darwin`

✅ No rebuilds

`aarch64-darwin`

✅ No rebuilds

Eveeifyeve · 2025-12-25T12:10:27Z

Please credit the suggestions provided by the reviewers via Co-authored-by so we are not breaking licensing.

While Co-authored-by metadata can be nice to have, I don't think it's a licensing requirement.

Git commit metadata isn't the authoritative source of copyright in nixpkgs; licensing is covered by COPYING, which attributes copyright collectively to:

Copyright (c) 2003-2025 Eelco Dolstra and the Nixpkgs/NixOS contributors

Regardless, I'm fine for my suggestions to be merged into Nixpkgs without attribution.

TL;DR: Adding Co-authored-by can be good practice, but it isn't required here for licensing reasons.

I thought it was, because a long time ago @emilazy said I needed to do it so I am confused now so it's not required?????

Co-Authored-By: Matt Sturgeon <[email protected]>

theCapypara force-pushed the jetbrains/update-src-2025.3 branch 4 times, most recently from 2a6c781 to a7aaf7b Compare December 15, 2025 10:30

theCapypara marked this pull request as ready for review December 15, 2025 10:31

nixpkgs-ci bot requested a review from leona-ya December 15, 2025 10:37

theCapypara requested review from MattSturgeon, aoli-al and jamesward December 15, 2025 10:42

theCapypara force-pushed the jetbrains/update-src-2025.3 branch from a7aaf7b to dbc7227 Compare December 15, 2025 11:00

MattSturgeon reviewed Dec 15, 2025

View reviewed changes

theCapypara force-pushed the jetbrains/update-src-2025.3 branch from dbc7227 to c3aa3d9 Compare December 15, 2025 14:08

This comment was marked as duplicate.

Sign in to view

theCapypara force-pushed the jetbrains/update-src-2025.3 branch 3 times, most recently from 600f692 to 7cfb37f Compare December 21, 2025 15:10

This comment was marked as duplicate.

Sign in to view

MattSturgeon reviewed Dec 24, 2025

View reviewed changes

pkgs/applications/editors/jetbrains/source/build.nix Outdated Show resolved Hide resolved

pkgs/applications/editors/jetbrains/source/build.nix Outdated Show resolved Hide resolved

pkgs/applications/editors/jetbrains/source/build.nix Outdated Show resolved Hide resolved

theCapypara force-pushed the jetbrains/update-src-2025.3 branch from 575a145 to a13fc3d Compare December 25, 2025 10:01

theCapypara requested a review from MattSturgeon December 25, 2025 10:02

theCapypara removed the backport release-25.11 Backport PR automatically label Dec 25, 2025

theCapypara marked this pull request as draft December 25, 2025 10:27

theCapypara changed the title ~~jetbrains: idea-oss, pycharm-oss: 2025.1.1.1 -> 2025.3~~ jetbrains: idea-oss, pycharm-oss: 2025.1.1.1 -> 2025.3.1 Dec 25, 2025

theCapypara force-pushed the jetbrains/update-src-2025.3 branch from a13fc3d to 3624c53 Compare December 25, 2025 10:48

theCapypara marked this pull request as ready for review December 25, 2025 10:48

theCapypara and others added 10 commits December 28, 2025 13:17

jetbrains: fix source update script

0df7021

jetbrains: update basic source dependencies and patches

88f949f

Co-Authored-By: Matt Sturgeon <[email protected]>

jetbrains: source builds: auto-update jps & restarter hashes

0e22158

jetbrains: source builds: fetch latest versions

996eb62

jetbrains: source builds: fixed & hardened maven deps update script

4dce2ed

jetbrains.*-oss: Add fallback URLs w/o the cache redirector

c583914

Co-Authored-By: Matt Sturgeon <[email protected]>

jetbrains.*-oss: Do not use hardcoded build dir paths

183d5dc

Co-Authored-By: Matt Sturgeon <[email protected]>

jetbrains.*-oss: replace brokenPlugins.json with an empty list

cea11ca

jetbrains: source build updates: write repositories without prefix

2ec9ec5

jetbrains: idea-oss, pycharm-oss: 2025.1.1.1 -> 2025.3.1

9724448

theCapypara force-pushed the jetbrains/update-src-2025.3 branch from 3624c53 to 9724448 Compare December 28, 2025 12:18

MattSturgeon added this pull request to the merge queue Dec 28, 2025

Merged via the queue into NixOS:master with commit 3474200 Dec 28, 2025
28 of 30 checks passed

theCapypara mentioned this pull request Dec 31, 2025

[Backport release-25.11] jetbrains.*: 2025.1.1.1 -> 2025.3.2 #475552

Merged

13 tasks

Uh oh!

Conversation

theCapypara commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

MattSturgeon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as duplicate.

theCapypara commented Dec 17, 2025

Uh oh!

MattSturgeon commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theCapypara commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

theCapypara commented Dec 19, 2025

Uh oh!

theCapypara commented Dec 21, 2025

Uh oh!

This comment was marked as duplicate.

theCapypara commented Dec 21, 2025

Uh oh!

MattSturgeon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theCapypara commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theCapypara commented Dec 25, 2025

Uh oh!

Eveeifyeve commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MattSturgeon commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MattSturgeon commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theCapypara commented Dec 25, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

Eveeifyeve commented Dec 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

theCapypara commented Dec 14, 2025 •

edited

Loading

MattSturgeon commented Dec 17, 2025 •

edited

Loading

theCapypara commented Dec 18, 2025 •

edited

Loading

theCapypara commented Dec 25, 2025 •

edited

Loading

Eveeifyeve commented Dec 25, 2025 •

edited

Loading

MattSturgeon commented Dec 25, 2025 •

edited

Loading

MattSturgeon commented Dec 25, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`