Doc: Minor fix for python virtualenv example in nix-shell#46909
Closed
MelleB wants to merge 1 commit intoNixOS:masterfrom
MelleB:patch-1
Closed
Doc: Minor fix for python virtualenv example in nix-shell#46909MelleB wants to merge 1 commit intoNixOS:masterfrom MelleB:patch-1
MelleB wants to merge 1 commit intoNixOS:masterfrom
MelleB:patch-1
Conversation
Closes #43737 Based on suggestion mentioned in #39558 (comment)
danbst
added a commit
to danbst/nixpkgs
that referenced
this pull request
Feb 5, 2019
- make it easy to switch python 2/3 - add glibcLocales dep (not sure it is still required after NixOS#54485 but manual is also used by users of Nixpkgs versions <19.03) - use `mkShell` - use `libffi`, as it is required for Python3 `cryptography` (in my setup it worked with Python2 without this dep) - set PYTHONPATH. Either this or `source venv/bin/activate` was missing. Closes NixOS#46909
Member
|
Any updates on this pull request, please? |
Contributor
|
closing in favor of #77569 |
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43737
Based on suggestion mentioned in #39558 (comment)
Motivation for this change
Took me some time to fix this, hope this helps someone else.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)